Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] #737 add field based rules support in correlation engine #812

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

jowg-amazon
Copy link
Collaborator

Description

Manual backport #737 to 2.x

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ct#737)

* add field based rules support in correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

* add field based rules support in correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

---------

Signed-off-by: Subhobrata Dey <[email protected]>
@jowg-amazon jowg-amazon changed the title Backport #737 to 2.x [Backport] #737 to 2.x Jan 18, 2024
@jowg-amazon jowg-amazon changed the title [Backport] #737 to 2.x [Backport 2.x] #737 to 2.x Jan 18, 2024
@jowg-amazon jowg-amazon changed the title [Backport 2.x] #737 to 2.x [Backport 2.x] #737 add field based rules support in correlation engine Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (658c2a3) 24.87% compared to head (004f4b6) 24.79%.

Files Patch % Lines
...arch/securityanalytics/correlation/JoinEngine.java 0.00% 52 Missing ⚠️
...arch/securityanalytics/model/CorrelationQuery.java 0.00% 15 Missing ⚠️
...earch/securityanalytics/model/CorrelationRule.java 0.00% 10 Missing ⚠️
...ics/transport/TransportCorrelateFindingAction.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #812      +/-   ##
============================================
- Coverage     24.87%   24.79%   -0.08%     
- Complexity     1024     1025       +1     
============================================
  Files           277      277              
  Lines         12662    12710      +48     
  Branches       1390     1400      +10     
============================================
+ Hits           3150     3152       +2     
- Misses         9246     9293      +47     
+ Partials        266      265       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbcd90 sbcd90 merged commit 1cf3743 into opensearch-project:2.x Feb 6, 2024
11 of 18 checks passed
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants