Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Custom log types] Show log types table, Log type creation workflow #677

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

amsiglan
Copy link
Collaborator

Description

Backport #674

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

amsiglan added 2 commits July 31, 2023 11:32
…pensearch-project#674)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #677 (8ba9add) into 2.x (d3688a4) will decrease coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #677      +/-   ##
==========================================
- Coverage   32.53%   31.94%   -0.59%     
==========================================
  Files         138      146       +8     
  Lines        4525     4639     +114     
  Branches      748      760      +12     
==========================================
+ Hits         1472     1482      +10     
- Misses       2876     2979     +103     
- Partials      177      178       +1     

see 14 files with indirect coverage changes

@amsiglan amsiglan merged commit c4df3d2 into opensearch-project:2.x Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant