Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom log types] Show log types table, Log type creation workflow #674

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

amsiglan
Copy link
Collaborator

Description

In this PR we have added below workflows in UX:

  • Create custom log types
  • Update log types
  • List log types in a table

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago
Copy link
Member

lezzago commented Jul 28, 2023

Overall LGTM, just need the unit tests to pass. Also not sure if cypress tests need to be updated or they have previous issues.

amsiglan added 2 commits July 28, 2023 11:28
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan
Copy link
Collaborator Author

Overall LGTM, just need the unit tests to pass. Also not sure if cypress tests need to be updated or they have previous issues.

Updated snapshots, UTs should pass now. Looking into cypress tests

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #674 (9c4a113) into main (15f2e2f) will decrease coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   32.53%   31.94%   -0.59%     
==========================================
  Files         138      146       +8     
  Lines        4525     4639     +114     
  Branches      748      760      +12     
==========================================
+ Hits         1472     1482      +10     
- Misses       2876     2979     +103     
- Partials      177      178       +1     

see 14 files with indirect coverage changes

amsiglan added 2 commits July 28, 2023 11:49
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan merged commit ddd78a6 into opensearch-project:main Jul 28, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-674-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ddd78a62e542f806b4528365a0253cb94c73012a
# Push it to GitHub
git push --set-upstream origin backport/backport-674-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-674-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-674-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ddd78a62e542f806b4528365a0253cb94c73012a
# Push it to GitHub
git push --set-upstream origin backport/backport-674-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-674-to-2.9.

amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jul 31, 2023
…pensearch-project#674)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jul 31, 2023
…pensearch-project#674)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Jul 31, 2023
…ion workflow (#677)

* [Custom log types] Show log types table, Log type creation workflow (#674)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* using 2.9 OSD for cypress testing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Jul 31, 2023
…ion workflow (#678)

* [Custom log types] Show log types table, Log type creation workflow (#674)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* using 2.9 OSD, SA for cypress testing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…ion workflow (opensearch-project#678)

* [Custom log types] Show log types table, Log type creation workflow (opensearch-project#674)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* using 2.9 OSD, SA for cypress testing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants