[Backport 2.9] [Backport 2.x] UX updates for correlations #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* minor UX updates Signed-off-by: Amardeepsingh Siglani <[email protected]> * ux improvements for correlations Signed-off-by: Amardeepsingh Siglani <[email protected]> * made more refactors for ux polish Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed comments in PR Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 205ee18) Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 65ea940)
amsiglan
approved these changes
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## 2.9 #642 +/- ##
==========================================
- Coverage 31.48% 31.31% -0.18%
==========================================
Files 138 138
Lines 4335 4375 +40
Branches 721 727 +6
==========================================
+ Hits 1365 1370 +5
- Misses 2832 2867 +35
Partials 138 138 |
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ect#635) (opensearch-project#642) * minor UX updates Signed-off-by: Amardeepsingh Siglani <[email protected]> * ux improvements for correlations Signed-off-by: Amardeepsingh Siglani <[email protected]> * made more refactors for ux polish Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed comments in PR Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 205ee18) Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 65ea940) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 65ea940 from #635