Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] UX updates for correlations #635

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 205ee18 from #619

* minor UX updates

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements for correlations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* made more refactors for ux polish

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed comments in PR

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 205ee18)
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #635 (b03751b) into 2.x (451861e) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #635      +/-   ##
==========================================
- Coverage   31.48%   31.31%   -0.18%     
==========================================
  Files         138      138              
  Lines        4335     4375      +40     
  Branches      721      778      +57     
==========================================
+ Hits         1365     1370       +5     
- Misses       2832     2867      +35     
  Partials      138      138              

see 12 files with indirect coverage changes

@amsiglan amsiglan merged commit 65ea940 into 2.x Jul 11, 2023
opensearch-trigger-bot bot added a commit that referenced this pull request Jul 11, 2023
* minor UX updates

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements for correlations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* made more refactors for ux polish

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed comments in PR

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 205ee18)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 65ea940)
amsiglan pushed a commit that referenced this pull request Jul 12, 2023
* minor UX updates

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements for correlations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* made more refactors for ux polish

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed comments in PR

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 205ee18)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 65ea940)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…ect#635) (opensearch-project#642)

* minor UX updates

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements for correlations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* made more refactors for ux polish

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed comments in PR

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 205ee18)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 65ea940)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant