Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/interval field can be empty #379

Conversation

jovancacvetkovic
Copy link

Description

Adds validation for interval field during detector creation workflow.

Issues Resolved

Closes #378

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jovancacvetkovic jovancacvetkovic requested a review from a team January 20, 2023 20:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #379 (66ed328) into main (ad62548) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   15.41%   15.39%   -0.02%     
==========================================
  Files         109      109              
  Lines        2887     2890       +3     
  Branches      476      476              
==========================================
  Hits          445      445              
- Misses       2403     2406       +3     
  Partials       39       39              
Impacted Files Coverage Δ
...nents/DefineDetector/containers/DefineDetector.tsx 2.50% <0.00%> (ø)
...eDetector/components/DetectorSchedule/Interval.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
@amsiglan amsiglan merged commit 4385660 into opensearch-project:main Jan 31, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-379-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 438566030c72a9a47d81d50d0fe1d321389c1954
# Push it to GitHub
git push --set-upstream origin backport/backport-379-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-379-to-2.x.

amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jan 31, 2023
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Create detector | Interval field can be empty opensearch-project#378

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
@amsiglan amsiglan mentioned this pull request Jan 31, 2023
1 task
AWSHurneyt pushed a commit that referenced this pull request Jan 31, 2023
* Feature/add role edit cypress tests (#377)

* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases #104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases #104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases #104

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Bugfix/interval field can be empty (#379)

* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Create detector | Interval field can be empty #378

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…ch-project#390)

* Feature/add role edit cypress tests (opensearch-project#377)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases opensearch-project#104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases opensearch-project#104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases opensearch-project#104

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Bugfix/interval field can be empty (opensearch-project#379)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Create detector | Interval field can be empty opensearch-project#378

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…ch-project#390)

* Feature/add role edit cypress tests (opensearch-project#377)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases opensearch-project#104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases opensearch-project#104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases opensearch-project#104

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Bugfix/interval field can be empty (opensearch-project#379)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Create detector | Interval field can be empty opensearch-project#378

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan added a commit that referenced this pull request Mar 16, 2024
* Feature/add role edit cypress tests (#377)

* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases #104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases #104

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Implement additional integration test cases #104

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Bugfix/interval field can be empty (#379)

* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Create detector | Interval field can be empty #378

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix PR failed tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Create detector | Interval field can be empty
5 participants