-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add role edit cypress tests #377
Merged
AWSHurneyt
merged 8 commits into
opensearch-project:main
from
jovancacvetkovic:feature/add_role_edit_cypress_tests
Jan 23, 2023
Merged
Feature/add role edit cypress tests #377
AWSHurneyt
merged 8 commits into
opensearch-project:main
from
jovancacvetkovic:feature/add_role_edit_cypress_tests
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#288 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ect#104 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into feature/add_role_edit_cypress_tests # Conflicts: # cypress/integration/2_rules.spec.js # cypress/support/commands.js
…ect#104 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ect#104 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into feature/add_role_edit_cypress_tests
amsiglan
approved these changes
Jan 19, 2023
AWSHurneyt
approved these changes
Jan 23, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-377-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b41857f0434a7a92321dd7117911902e5142e0af
# Push it to GitHub
git push --set-upstream origin backport/backport-377-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
amsiglan
pushed a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Jan 31, 2023
* [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Feature/add role edit cypress tests (#377) * [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases #104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases #104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases #104 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> * Bugfix/interval field can be empty (#379) * [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Create detector | Interval field can be empty #378 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…ch-project#390) * Feature/add role edit cypress tests (opensearch-project#377) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> * Bugfix/interval field can be empty (opensearch-project#379) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Create detector | Interval field can be empty opensearch-project#378 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ch-project#390) * Feature/add role edit cypress tests (opensearch-project#377) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases opensearch-project#104 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> * Bugfix/interval field can be empty (opensearch-project#379) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Create detector | Interval field can be empty opensearch-project#378 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Mar 16, 2024
* Feature/add role edit cypress tests (#377) * [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases #104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases #104 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Implement additional integration test cases #104 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> * Bugfix/interval field can be empty (#379) * [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Create detector | Interval field can be empty #378 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * fix PR failed tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> * testing github-action v5 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds edit rules workflow cypress tests
Issues Resolved
Closes #104
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.