Feature/flyout alert name validation #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#288 Signed-off-by: Jovan Cvetkovic <[email protected]>
…pensearch-project#364 Signed-off-by: Jovan Cvetkovic <[email protected]>
…out opensearch-project#352 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into feature/flyout_alert_name_validation
amsiglan
approved these changes
Jan 17, 2023
…-analytics-dashboards-plugin into feature/flyout_alert_name_validation
AWSHurneyt
approved these changes
Jan 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add cypress custom commands to support better type events #364 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Trigger name should be required in Create alert trigger flyout #352 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 50430e3)
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 18, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add cypress custom commands to support better type events #364 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Trigger name should be required in Create alert trigger flyout #352 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 50430e3) Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…arch-project#374) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add cypress custom commands to support better type events opensearch-project#364 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Trigger name should be required in Create alert trigger flyout opensearch-project#352 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 50430e3) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…arch-project#374) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add cypress custom commands to support better type events opensearch-project#364 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Trigger name should be required in Create alert trigger flyout opensearch-project#352 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 50430e3) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add cypress custom commands to support better type events #364 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Trigger name should be required in Create alert trigger flyout #352 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 50430e3) Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds validation for trigger name in creating alert flyout.
Issues Resolved
Closes #352
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.