Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Trigger name should be required in Create alert trigger flyout #352

Closed
kamingleung opened this issue Jan 11, 2023 · 2 comments · Fixed by #367
Closed

[FEATURE] Trigger name should be required in Create alert trigger flyout #352

kamingleung opened this issue Jan 11, 2023 · 2 comments · Fixed by #367
Assignees
Labels
enhancement New feature or request untriaged

Comments

@kamingleung
Copy link

kamingleung commented Jan 11, 2023

Is your feature request related to a problem?
When creating a detector alert trigger from the findings page, if a user didn't enter a required field (e.g. Trigger Name), clicking on "Create alert trigger" will let users proceed to create. Trigger name should be required just like in the Create detector flow. Without a trigger name, it is difficult to identify what the alert is about.

What solution would you like?

  1. Users go to "Findings" page, click on the bell icon of a finding to open the Create alert trigger flyout.
    image
  2. When users open the flyout, the Trigger name field should be focused to guide users to fill in a name:

image

3. On blur, we should display a validation error if the trigger name is left empty. `Trigger name is required.`:

image

4. If required fields are not filled in, we should keep the Create button disabled:

image

@kamingleung kamingleung added enhancement New feature or request untriaged labels Jan 11, 2023
@kamingleung kamingleung changed the title [FEATURE] Trigger name is required for Create alert trigger flyout [FEATURE] Trigger name should be required in Create alert trigger flyout Jan 11, 2023
@amsiglan amsiglan self-assigned this Jan 12, 2023
@jovancacvetkovic
Copy link

@kamingleung, @amsiglan I noticed that users can create alerts from a flyout without a rule or severity. Creating a detector also allows these fields to be empty.
Is this OK behavior?

jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 14, 2023
AWSHurneyt pushed a commit that referenced this issue Jan 18, 2023
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add cypress custom commands to support better type events #364

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Trigger name should be required in Create alert trigger flyout #352

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 18, 2023
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add cypress custom commands to support better type events #364

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Trigger name should be required in Create alert trigger flyout #352

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 50430e3)
@kamingleung
Copy link
Author

@jovancacvetkovic The Rule and Severity fields can be empty. If these two fields are empty, it means it will include any rules and any severities:
image

AWSHurneyt pushed a commit that referenced this issue Jan 18, 2023
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add cypress custom commands to support better type events #364

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Trigger name should be required in Create alert trigger flyout #352

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 50430e3)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
…arch-project#374)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add cypress custom commands to support better type events opensearch-project#364

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Trigger name should be required in Create alert trigger flyout opensearch-project#352

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 50430e3)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
…arch-project#374)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add cypress custom commands to support better type events opensearch-project#364

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Trigger name should be required in Create alert trigger flyout opensearch-project#352

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 50430e3)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this issue Mar 16, 2024
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add cypress custom commands to support better type events #364

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Trigger name should be required in Create alert trigger flyout #352

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 50430e3)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants