Status chart colors update #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#288 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into bugfix/alerts_status_chart_colors
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]>
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]>
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic
changed the title
amsiglan
approved these changes
Jan 10, 2023
AWSHurneyt
approved these changes
Jan 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart #299 [BUG] Change color for Alerts SEVERITY chart #300 [BUG] Change color for Finding RULE SEVERITY chart #301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart #299 [BUG] Change color for Alerts SEVERITY chart #300 [BUG] Change color for Finding RULE SEVERITY chart #301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart #299 [BUG] Change color for Alerts SEVERITY chart #300 [BUG] Change color for Finding RULE SEVERITY chart #301 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit f3ddb23)
amsiglan
pushed a commit
that referenced
this pull request
Jan 10, 2023
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart #299 [BUG] Change color for Alerts SEVERITY chart #300 [BUG] Change color for Finding RULE SEVERITY chart #301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart #299 [BUG] Change color for Alerts SEVERITY chart #300 [BUG] Change color for Finding RULE SEVERITY chart #301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart #299 [BUG] Change color for Alerts SEVERITY chart #300 [BUG] Change color for Finding RULE SEVERITY chart #301 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit f3ddb23) Co-authored-by: Jovan Cvetkovic <[email protected]>
kamingleung
reviewed
Jan 11, 2023
| let states = ['ACTIVE', 'ACKNOWLEDGED']; | ||
| const statusColors = { | ||
| euiColorVis6: '#B9A888', | ||
| euiColorVis9: '#E7664C', |
There was a problem hiding this comment.
@jovancacvetkovic @amsiglan Active should be euiColorVis9 and acknowledged should be euiColorVis6.
Incorrect colors shown in screenshot:
There was a problem hiding this comment.
@kamingleung you are right, I switched the colors, and fixed in the next PR (under review PR #350 350)
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…ct#312) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart opensearch-project#299 [BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart opensearch-project#299 [BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart opensearch-project#299 [BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit f3ddb23) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ct#312) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart opensearch-project#299 [BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart opensearch-project#299 [BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Change colors for Alerts STATUS chart opensearch-project#299 [BUG] Change color for Alerts SEVERITY chart opensearch-project#300 [BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit f3ddb23) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves chart color palette issues
Issues Resolved
Closes #299
Closes #300
Closes #301
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.