Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Change colors for Alerts STATUS chart #299

Closed
kamingleung opened this issue Jan 10, 2023 · 0 comments · Fixed by #309
Closed

[BUG] Change colors for Alerts STATUS chart #299

kamingleung opened this issue Jan 10, 2023 · 0 comments · Fixed by #309
Labels
bug Something isn't working untriaged

Comments

@kamingleung
Copy link

kamingleung commented Jan 10, 2023 •
edited
Loading

What is the bug?
In Security alerts page, The chart colors for alert status don't convey the meaning of the actual statuses. Both Active and Acknowledged status are in green.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to 'Security alerts'
  2. Choose 'Group by: Alert status'

What is the expected behavior?
For Active alerts, use euiColorVis9 #E7664C.
For Acknowledged alerts, use euiColorVis6 #B9A888.
See Colors guideline for details

Do you have any screenshots?
image
@kamingleung kamingleung added bug Something isn't working untriaged labels Jan 10, 2023
@kamingleung kamingleung changed the title [BUG] Change colors for Alerts status chart [BUG] Change colors for Alerts STATUS chart Jan 10, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 10, 2023
@jovancvetkovic3006
[BUG] Change colors for Alerts STATUS chart opensearch-project#299
9ac8923 
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 10, 2023
@jovancvetkovic3006
[BUG] Change colors for Alerts STATUS chart opensearch-project#299
d820ee8 
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 10, 2023
@jovancvetkovic3006
[BUG] Change colors for Alerts STATUS chart opensearch-project#299
a37f54f 
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue Jan 10, 2023
Merged
1 task
AWSHurneyt pushed a commit that referenced this issue Jan 10, 2023
@jovancvetkovic3006
Status chart colors update (#309)
f3ddb23 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready to work on to Done in Security analytics dashboards 2.5 release Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 10, 2023
@jovancvetkovic3006 @github-actions
Status chart colors update (#309)
f3b14cc 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit f3ddb23)
amsiglan pushed a commit that referenced this issue Jan 10, 2023
@opensearch-trigger-bot @jovancvetkovic3006
Status chart colors update (#309) (#312)
773a852 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart #299
[BUG] Change color for Alerts SEVERITY chart #300
[BUG] Change color for Finding RULE SEVERITY chart #301

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit f3ddb23)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Status chart colors update (opensearch-project#309) (opensearch-proje…
3f72e37 
…ct#312)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit f3ddb23)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Status chart colors update (opensearch-project#309) (opensearch-proje…
d3a8aa5 
…ct#312)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit f3ddb23)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged
Projects
Security analytics dashboards 2.5 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Status chart colors update jovancacvetkovic/security-analytics-dashboards-plugin
1 participant
@kamingleung