Feature/charts should show the entire time range selected in the filter #258 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 Signed-off-by: Jovan Cvetkovic <[email protected]>
… for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into feature/Charts_should_show_the_entire_time_range_selected_in_the_filter_#258
… for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]>
… for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]>
… for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]>
… for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]>
… for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan
approved these changes
Dec 28, 2022
amsiglan
reviewed
Dec 28, 2022
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
getsaurabh02
approved these changes
Dec 29, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
#258 (#265) * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 2ccadad)
amsiglan
pushed a commit
that referenced
this pull request
Dec 29, 2022
#258 (#265) (#274) * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253 [FEATURE] Charts should show the entire time range selected in the filter #258 [FEATURE] Add chart data to the tooltips #263 Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 2ccadad) Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
opensearch-project#258 (opensearch-project#265) (opensearch-project#274) * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 2ccadad) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
opensearch-project#258 (opensearch-project#265) (opensearch-project#274) * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253 [FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258 [FEATURE] Add chart data to the tooltips opensearch-project#263 Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * PR 265 Code review Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 2ccadad) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets default time filter to last 24h and applies the same to all pages.
Sets all data from the chart into chart tooltips.
Sets time range exactly as in time filter.
Issues Resolved
Closes #263
Closes #258
Closes #253
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.