Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253

Closed
amsiglan opened this issue Dec 21, 2022 · 0 comments · Fixed by #265
Closed

[FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253

amsiglan opened this issue Dec 21, 2022 · 0 comments · Fixed by #265
Labels
enhancement New feature or request

Comments

@amsiglan
Copy link
Collaborator

amsiglan commented Dec 21, 2022 •
edited
Loading

Is your feature request related to a problem?

  1. The default time range used for time filter is 15 min which is too small to show meaningful data.
  2. User has to change the time filter every time they go to a different page

What solution would you like?

  1. Default time should be 24 hrs so that we can show more data
  2. The time range should be cached and applied to all the pages

What alternatives have you considered?

  1. We can iterate on this based on user feedback in the future
  2. NA

Do you have any additional context?
Filter control:
image
@amsiglan amsiglan added the enhancement New feature or request label Dec 21, 2022
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 27, 2022
@jovancvetkovic3006
[FEATURE] Set default time range to 24 hrs and share the same setting…
4d9db71 
… for all UI pages opensearch-project#253

[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 27, 2022
@jovancvetkovic3006
[FEATURE] Set default time range to 24 hrs and share the same setting…
b2ba85a 
… for all UI pages opensearch-project#253

[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 27, 2022
@jovancvetkovic3006
[FEATURE] Set default time range to 24 hrs and share the same setting…
b7a13e7 
… for all UI pages opensearch-project#253

[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 27, 2022
@jovancvetkovic3006
[FEATURE] Set default time range to 24 hrs and share the same setting…
4311506 
… for all UI pages opensearch-project#253

[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 27, 2022
@jovancvetkovic3006
[FEATURE] Set default time range to 24 hrs and share the same setting…
9abd700 
… for all UI pages opensearch-project#253

[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue Dec 27, 2022
Merged
1 task
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 27, 2022
@jovancvetkovic3006
[FEATURE] Set default time range to 24 hrs and share the same setting…
a49e84e 
… for all UI pages opensearch-project#253

[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 28, 2022
@jovancvetkovic3006
[FEATURE] Set default time range to 24 hrs and share the same setting…
f094961 
… for all UI pages opensearch-project#253

[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan pushed a commit that referenced this issue Dec 29, 2022
@jovancvetkovic3006
Feature/charts should show the entire time range selected in the filter
2ccadad 
#258 (#265)

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Dec 29, 2022
@jovancvetkovic3006 @github-actions
Feature/charts should show the entire time range selected in the filter
99c02d0 
#258 (#265)

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 2ccadad)
amsiglan pushed a commit that referenced this issue Dec 29, 2022
@opensearch-trigger-bot @jovancvetkovic3006
Feature/charts should show the entire time range selected in the filter
bea231a 
#258 (#265) (#274)

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages #253
[FEATURE] Charts should show the entire time range selected in the filter #258
[FEATURE] Add chart data to the tooltips #263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 2ccadad)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Feature/charts should show the entire time range selected in the filter
65b54e2 
opensearch-project#258 (opensearch-project#265) (opensearch-project#274)

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 2ccadad)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Feature/charts should show the entire time range selected in the filter
f399669 
opensearch-project#258 (opensearch-project#265) (opensearch-project#274)

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Set default time range to 24 hrs and share the same setting for all UI pages opensearch-project#253
[FEATURE] Charts should show the entire time range selected in the filter opensearch-project#258
[FEATURE] Add chart data to the tooltips opensearch-project#263

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR 265 Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 2ccadad)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@amsiglan