[Backport 2.x] Rule flyout opening from Findings and Alerts page #230
+95
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* rule flyout opening from findings and alerts page Signed-off-by: Aleksandar Djindjic <[email protected]> * update cypress test for findings page Signed-off-by: Aleksandar Djindjic <[email protected]> * make code shorter Signed-off-by: Aleksandar Djindjic <[email protected]> * toast error notifications for rule deletion Signed-off-by: Aleksandar Djindjic <[email protected]> * cleanup component state Signed-off-by: Aleksandar Djindjic <[email protected]> * avoid as any in favor of RuleItemInfoBase Signed-off-by: Aleksandar Djindjic <[email protected]> * fix cypress test for rules Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 11e47b3)
amsiglan
approved these changes
Dec 19, 2022
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…#219) (opensearch-project#230) * rule flyout opening from findings and alerts page Signed-off-by: Aleksandar Djindjic <[email protected]> * update cypress test for findings page Signed-off-by: Aleksandar Djindjic <[email protected]> * make code shorter Signed-off-by: Aleksandar Djindjic <[email protected]> * toast error notifications for rule deletion Signed-off-by: Aleksandar Djindjic <[email protected]> * cleanup component state Signed-off-by: Aleksandar Djindjic <[email protected]> * avoid as any in favor of RuleItemInfoBase Signed-off-by: Aleksandar Djindjic <[email protected]> * fix cypress test for rules Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 11e47b3) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…#219) (opensearch-project#230) * rule flyout opening from findings and alerts page Signed-off-by: Aleksandar Djindjic <[email protected]> * update cypress test for findings page Signed-off-by: Aleksandar Djindjic <[email protected]> * make code shorter Signed-off-by: Aleksandar Djindjic <[email protected]> * toast error notifications for rule deletion Signed-off-by: Aleksandar Djindjic <[email protected]> * cleanup component state Signed-off-by: Aleksandar Djindjic <[email protected]> * avoid as any in favor of RuleItemInfoBase Signed-off-by: Aleksandar Djindjic <[email protected]> * fix cypress test for rules Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 11e47b3) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 11e47b3 from #219