Rule flyout opening from Findings and Alerts page #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
amsiglan
reviewed
Dec 14, 2022
Comment on lines
56
to
61
| if (!history) { | ||
| return; | ||
| } | ||
| history.push({ | ||
| pathname: ROUTES.RULES_EDIT, | ||
| state: { ruleItem: ruleTableItem.ruleInfo }, |
There was a problem hiding this comment.
Can we clubbed into
history?.push(...)
amsiglan
reviewed
Dec 14, 2022
Comment on lines
46
to
49
| if (!history) { | ||
| return; | ||
| } | ||
| history.push({ |
There was a problem hiding this comment.
Club together into
history?.push(...)
amsiglan
reviewed
Dec 14, 2022
| @@ -74,6 +81,9 @@ export const RuleViewerFlyout: React.FC<RuleViewerFlyoutProps> = ({ | |||
| }; | |||
|
|
|||
| const onDeleteRuleConfirmed = async () => { | |||
| if (!ruleService) { | |||
| return; | |||
| } | |||
| const deleteRuleRes = await ruleService.deleteRule(ruleTableItem.ruleId); | |||
|
|
|||
| if (!deleteRuleRes.ok) { | |||
There was a problem hiding this comment.
Let's fix this Todo? we can show an error toast saying Failed to delete rule
There was a problem hiding this comment.
check this commit, I think its a right error handling here now:
dae1c8f#diff-ddf4d433db9a97c023d49ad7aeb681cf5376c5248d42f51246485942e687863fR86
amsiglan
reviewed
Dec 14, 2022
| @@ -45,6 +50,8 @@ export default class FindingDetailsFlyout extends Component< | |||
| super(props); | |||
| this.state = { | |||
| loading: false, | |||
| ruleViewerFlyoutShown: false, | |||
There was a problem hiding this comment.
This boolean seems redundant since we are anyways rendering the flyout based on the data. I think just ruleViewerFlyoutData is enough for check. Thoughts?
There was a problem hiding this comment.
Totally right. I've cleaned it up
amsiglan
reviewed
Dec 14, 2022
| source: fullRule.source, | ||
| ruleInfo: { | ||
| _source: fullRule, | ||
| } as any, |
There was a problem hiding this comment.
Why do we need to use as any here?
There was a problem hiding this comment.
I've changed it to as RuleItemInfoBase which is more appropriate.
TS assertion is needed because we don't have all the data to construct whole object. Other properties are anyway not in use in the Rule flyout.
Let me know if you have some better idea.
amsiglan
reviewed
Dec 14, 2022
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
amsiglan
approved these changes
Dec 16, 2022
sbcd90
approved these changes
Dec 16, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
* rule flyout opening from findings and alerts page Signed-off-by: Aleksandar Djindjic <[email protected]> * update cypress test for findings page Signed-off-by: Aleksandar Djindjic <[email protected]> * make code shorter Signed-off-by: Aleksandar Djindjic <[email protected]> * toast error notifications for rule deletion Signed-off-by: Aleksandar Djindjic <[email protected]> * cleanup component state Signed-off-by: Aleksandar Djindjic <[email protected]> * avoid as any in favor of RuleItemInfoBase Signed-off-by: Aleksandar Djindjic <[email protected]> * fix cypress test for rules Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 11e47b3)
amsiglan
pushed a commit
that referenced
this pull request
Dec 19, 2022
* rule flyout opening from findings and alerts page Signed-off-by: Aleksandar Djindjic <[email protected]> * update cypress test for findings page Signed-off-by: Aleksandar Djindjic <[email protected]> * make code shorter Signed-off-by: Aleksandar Djindjic <[email protected]> * toast error notifications for rule deletion Signed-off-by: Aleksandar Djindjic <[email protected]> * cleanup component state Signed-off-by: Aleksandar Djindjic <[email protected]> * avoid as any in favor of RuleItemInfoBase Signed-off-by: Aleksandar Djindjic <[email protected]> * fix cypress test for rules Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 11e47b3) Co-authored-by: Aleksandar Djindjic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…#219) (opensearch-project#230) * rule flyout opening from findings and alerts page Signed-off-by: Aleksandar Djindjic <[email protected]> * update cypress test for findings page Signed-off-by: Aleksandar Djindjic <[email protected]> * make code shorter Signed-off-by: Aleksandar Djindjic <[email protected]> * toast error notifications for rule deletion Signed-off-by: Aleksandar Djindjic <[email protected]> * cleanup component state Signed-off-by: Aleksandar Djindjic <[email protected]> * avoid as any in favor of RuleItemInfoBase Signed-off-by: Aleksandar Djindjic <[email protected]> * fix cypress test for rules Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 11e47b3) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…#219) (opensearch-project#230) * rule flyout opening from findings and alerts page Signed-off-by: Aleksandar Djindjic <[email protected]> * update cypress test for findings page Signed-off-by: Aleksandar Djindjic <[email protected]> * make code shorter Signed-off-by: Aleksandar Djindjic <[email protected]> * toast error notifications for rule deletion Signed-off-by: Aleksandar Djindjic <[email protected]> * cleanup component state Signed-off-by: Aleksandar Djindjic <[email protected]> * avoid as any in favor of RuleItemInfoBase Signed-off-by: Aleksandar Djindjic <[email protected]> * fix cypress test for rules Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 11e47b3) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reusing existing Rule details flyout in Findings and Alerts page
Issues Resolved
Closes #124
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.