-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML Rule Editor Support #201
Merged
AWSHurneyt
merged 16 commits into
opensearch-project:main
from
djindjic:feature/refactor-rule-editor
Dec 9, 2022
Merged
YAML Rule Editor Support #201
AWSHurneyt
merged 16 commits into
opensearch-project:main
from
djindjic:feature/refactor-rule-editor
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
djindjic
force-pushed
the
feature/refactor-rule-editor
branch
from
December 6, 2022 19:39
0407ba9
to
55f3b5f
Compare
Signed-off-by: Aleksandar Djindjic <[email protected]>
amsiglan
reviewed
Dec 8, 2022
public/pages/Rules/components/RuleEditor/RuleEditorFormState.model.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
amsiglan
approved these changes
Dec 9, 2022
AWSHurneyt
approved these changes
Dec 9, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-201-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b6af15c278e7e253cd81c95bcbbcd73e2cfb092
# Push it to GitHub
git push --set-upstream origin backport/backport-201-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
djindjic
added a commit
to djindjic/security-analytics-dashboards-plugin
that referenced
this pull request
Dec 9, 2022
* remove unused service Signed-off-by: Aleksandar Djindjic <[email protected]> * refactor form state Signed-off-by: Aleksandar Djindjic <[email protected]> * extract model and mappers Signed-off-by: Aleksandar Djindjic <[email protected]> * Extract Visual Rule Editor Component Signed-off-by: Aleksandar Djindjic <[email protected]> * fix missing default id Signed-off-by: Aleksandar Djindjic <[email protected]> * yaml editor Signed-off-by: Aleksandar Djindjic <[email protected]> * yaml rule editor mappings Signed-off-by: Aleksandar Djindjic <[email protected]> * more mapping guards Signed-off-by: Aleksandar Djindjic <[email protected]> * remove console.log's Signed-off-by: Aleksandar Djindjic <[email protected]> * YAML editor - cypress test Signed-off-by: Aleksandar Djindjic <[email protected]> * yaml editor snapshot test Signed-off-by: Aleksandar Djindjic <[email protected]> * rename model Signed-off-by: Aleksandar Djindjic <[email protected]> * more validations on yaml editor Signed-off-by: Aleksandar Djindjic <[email protected]> * use eui form validation error box Signed-off-by: Aleksandar Djindjic <[email protected]> * re-generate snapshot Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]>
djindjic
added a commit
to djindjic/security-analytics-dashboards-plugin
that referenced
this pull request
Dec 9, 2022
* remove unused service Signed-off-by: Aleksandar Djindjic <[email protected]> * refactor form state Signed-off-by: Aleksandar Djindjic <[email protected]> * extract model and mappers Signed-off-by: Aleksandar Djindjic <[email protected]> * Extract Visual Rule Editor Component Signed-off-by: Aleksandar Djindjic <[email protected]> * fix missing default id Signed-off-by: Aleksandar Djindjic <[email protected]> * yaml editor Signed-off-by: Aleksandar Djindjic <[email protected]> * yaml rule editor mappings Signed-off-by: Aleksandar Djindjic <[email protected]> * more mapping guards Signed-off-by: Aleksandar Djindjic <[email protected]> * remove console.log's Signed-off-by: Aleksandar Djindjic <[email protected]> * YAML editor - cypress test Signed-off-by: Aleksandar Djindjic <[email protected]> * yaml editor snapshot test Signed-off-by: Aleksandar Djindjic <[email protected]> * rename model Signed-off-by: Aleksandar Djindjic <[email protected]> * more validations on yaml editor Signed-off-by: Aleksandar Djindjic <[email protected]> * use eui form validation error box Signed-off-by: Aleksandar Djindjic <[email protected]> * re-generate snapshot Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]>
1 task
amsiglan
added a commit
that referenced
this pull request
Jan 9, 2023
* resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated latest code from the main branch Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated integration test to latest from main Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Aleksandar Djindjic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]>
4 tasks
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…opensearch-project#248, opensearch-project#261 (opensearch-project#287) * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated latest code from the main branch Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated integration test to latest from main Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Aleksandar Djindjic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…opensearch-project#248, opensearch-project#261 (opensearch-project#287) * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved conflicts Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated latest code from the main branch Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated integration test to latest from main Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Aleksandar Djindjic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add YAML editor support
Issues Resolved
#154
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.