Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML Rule Editor Support #201

Merged

Conversation

djindjic
Copy link
Contributor

@djindjic djindjic commented Dec 6, 2022

Description

Add YAML editor support

Issues Resolved

#154

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@djindjic djindjic requested a review from a team December 6, 2022 19:36
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic djindjic force-pushed the feature/refactor-rule-editor branch from 0407ba9 to 55f3b5f Compare December 6, 2022 19:39
@djindjic djindjic changed the title Feature/refactor rule editor YAML Editor Support Dec 6, 2022
@djindjic djindjic changed the title YAML Editor Support YAML Rule Editor Support Dec 6, 2022
Signed-off-by: Aleksandar Djindjic <[email protected]>
@AWSHurneyt AWSHurneyt merged commit 6b6af15 into opensearch-project:main Dec 9, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-201-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b6af15c278e7e253cd81c95bcbbcd73e2cfb092
# Push it to GitHub
git push --set-upstream origin backport/backport-201-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-201-to-2.x.

djindjic added a commit to djindjic/security-analytics-dashboards-plugin that referenced this pull request Dec 9, 2022
* remove unused service

Signed-off-by: Aleksandar Djindjic <[email protected]>

* refactor form state

Signed-off-by: Aleksandar Djindjic <[email protected]>

* extract model and mappers

Signed-off-by: Aleksandar Djindjic <[email protected]>

* Extract Visual Rule Editor Component

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix missing default id

Signed-off-by: Aleksandar Djindjic <[email protected]>

* yaml editor

Signed-off-by: Aleksandar Djindjic <[email protected]>

* yaml rule editor mappings

Signed-off-by: Aleksandar Djindjic <[email protected]>

* more mapping guards

Signed-off-by: Aleksandar Djindjic <[email protected]>

* remove console.log's

Signed-off-by: Aleksandar Djindjic <[email protected]>

* YAML editor - cypress test

Signed-off-by: Aleksandar Djindjic <[email protected]>

* yaml editor snapshot test

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rename model

Signed-off-by: Aleksandar Djindjic <[email protected]>

* more validations on yaml editor

Signed-off-by: Aleksandar Djindjic <[email protected]>

* use eui form validation error box

Signed-off-by: Aleksandar Djindjic <[email protected]>

* re-generate snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
djindjic added a commit to djindjic/security-analytics-dashboards-plugin that referenced this pull request Dec 9, 2022
* remove unused service

Signed-off-by: Aleksandar Djindjic <[email protected]>

* refactor form state

Signed-off-by: Aleksandar Djindjic <[email protected]>

* extract model and mappers

Signed-off-by: Aleksandar Djindjic <[email protected]>

* Extract Visual Rule Editor Component

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix missing default id

Signed-off-by: Aleksandar Djindjic <[email protected]>

* yaml editor

Signed-off-by: Aleksandar Djindjic <[email protected]>

* yaml rule editor mappings

Signed-off-by: Aleksandar Djindjic <[email protected]>

* more mapping guards

Signed-off-by: Aleksandar Djindjic <[email protected]>

* remove console.log's

Signed-off-by: Aleksandar Djindjic <[email protected]>

* YAML editor - cypress test

Signed-off-by: Aleksandar Djindjic <[email protected]>

* yaml editor snapshot test

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rename model

Signed-off-by: Aleksandar Djindjic <[email protected]>

* more validations on yaml editor

Signed-off-by: Aleksandar Djindjic <[email protected]>

* use eui form validation error box

Signed-off-by: Aleksandar Djindjic <[email protected]>

* re-generate snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
amsiglan added a commit that referenced this pull request Jan 9, 2023
* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated latest code from the main branch

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated integration test to latest from main

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Aleksandar Djindjic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…opensearch-project#248, opensearch-project#261 (opensearch-project#287)

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated latest code from the main branch

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated integration test to latest from main

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Aleksandar Djindjic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…opensearch-project#248, opensearch-project#261 (opensearch-project#287)

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated latest code from the main branch

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated integration test to latest from main

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Aleksandar Djindjic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants