Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Cypress testing rule edit enhancement #208

Closed
djindjic opened this issue Dec 9, 2022 · 1 comment · Fixed by #248
Closed

[FEATURE] Cypress testing rule edit enhancement #208

djindjic opened this issue Dec 9, 2022 · 1 comment · Fixed by #248
Labels
enhancement New feature or request

Comments

@djindjic
Copy link
Contributor

djindjic commented Dec 9, 2022 •
edited
Loading

Is your feature request related to a problem?
Reuse <EuiCodeEditor> content expects base on this PR comment.
#201 (comment)
@djindjic djindjic added the enhancement New feature or request label Dec 9, 2022
@djindjic djindjic mentioned this issue Dec 9, 2022
Merged
1 task
@djindjic djindjic mentioned this issue Dec 21, 2022
Merged
1 task
@djindjic
Copy link
Contributor Author

As pointed out in PR comment referenced in issues description, I've reused same selector [class="euiCodeBlock__line"] to iterate through <EuiCodeBlock> on rule details flyout YAML content. Unfortunately, this is not possible to do in similar way on <EuiCodeEditor> on rule edit mode, but it's still covered by already existing contains like expectations.

Keeping @AWSHurneyt in the line based on our offline discussion. If we are able to give a feedback to OIU team, we could also propose additional data-test-subj attributes on either <EuiCodeBlock> and <EuiCodeEditor> to avoid targeting inner elements on class attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cypress checking on rule YAML content djindjic/security-analytics-dashboards-plugin
1 participant
@djindjic