Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS #396

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Baseline MAINTAINERS, CODEOWNERS #396

merged 2 commits into from
Mar 8, 2023

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Mar 7, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixes #382

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dzane17 dzane17 marked this pull request as ready for review March 7, 2023 22:51
@dzane17 dzane17 requested review from a team, dblock and kkhatua March 7, 2023 22:51
@codecov-commenter
Copy link

Codecov Report

Merging #396 (c32f5cd) into main (83ee108) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head c32f5cd differs from pull request most recent head c7467ad. Consider uploading reports for the commit c7467ad to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #396      +/-   ##
============================================
+ Coverage     70.88%   71.04%   +0.15%     
- Complexity      377      378       +1     
============================================
  Files            44       44              
  Lines          2597     2597              
  Branches        176      176              
============================================
+ Hits           1841     1845       +4     
+ Misses          647      644       -3     
+ Partials        109      108       -1     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 60.71% <0.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CODEOWNERS Outdated
@@ -0,0 +1,3 @@
@samenp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct file location in the repo already exists.
https://github.com/opensearch-project/performance-analyzer/blob/main/.github/CODEOWNERS

And I don't think this file's contents are needed there as it already calls out the owning team.

You can remove this file in your revision.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I got confused because some repos use .github/CODEOWNERS and some use CODEOWNERS.

The ask is to replace team aliases with individuals so I will update the existing file.

4. Add active maintainers to CODEOWNERS.
5. Remove any broad teams from CODEOWNERS.

@dzane17 dzane17 merged commit 56e3044 into main Mar 8, 2023
@dzane17 dzane17 deleted the feature/maintainers branch March 8, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
4 participants