-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline MAINTAINERS, CODEOWNERS #396
Conversation
Signed-off-by: David Zane <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #396 +/- ##
============================================
+ Coverage 70.88% 71.04% +0.15%
- Complexity 377 378 +1
============================================
Files 44 44
Lines 2597 2597
Branches 176 176
============================================
+ Hits 1841 1845 +4
+ Misses 647 644 -3
+ Partials 109 108 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
CODEOWNERS
Outdated
@@ -0,0 +1,3 @@ | |||
@samenp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct file location in the repo already exists.
https://github.com/opensearch-project/performance-analyzer/blob/main/.github/CODEOWNERS
And I don't think this file's contents are needed there as it already calls out the owning team.
You can remove this file in your revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I got confused because some repos use .github/CODEOWNERS
and some use CODEOWNERS
.
- https://github.com/opensearch-project/opensearch-build/blob/main/.github/CODEOWNERS
- https://github.com/opensearch-project/project-tools/blob/main/CODEOWNERS
The ask is to replace team aliases with individuals so I will update the existing file.
4. Add active maintainers to CODEOWNERS.
5. Remove any broad teams from CODEOWNERS.
Signed-off-by: David Zane <[email protected]>
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixes #382
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.