Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #382

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 6 comments · Fixed by #396
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #382

dblock opened this issue Feb 14, 2023 · 6 comments · Fixed by #396

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@kkhatua
Copy link
Member

kkhatua commented Mar 7, 2023

@dzane17 please update the file to reflect the team correctly:
https://github.com/orgs/opensearch-project/teams/performance-analyzer/members
This needs to be done for RCA as well.

@dblock
Copy link
Member Author

dblock commented Mar 9, 2023

You have the performance analyzer team with 13 members that have maintain access to this repo and a plugins team with 8 members that has admin access. Only folks listed in MAINTAINERS/CODEOWNERS need to have maintain access, and groups don't support external collaborators and therefore should be removed except for admin. Please work with an admin to remove the group, and add individuals.

@praveensameneni
Copy link
Member

We will update the MAINTAINERS in the performance analyzer team

@gaiksaya
Copy link
Member

gaiksaya commented Apr 17, 2023

The permissions have been updated for this repository!

Here is the snippet
image

@khushbr @praveensameneni Please verify and close the issue if needed.
Thanks!

@khushbr khushbr closed this as completed Apr 18, 2023
@khushbr
Copy link
Collaborator

khushbr commented Apr 18, 2023

LGTM! Thank you @gaiksaya !

@dblock
Copy link
Member Author

dblock commented Apr 20, 2023

Verified, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants