Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] Increment version to 1.3.6-SNAPSHOT & Update Jackson #267

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Sep 9, 2022

  • Incremented version to 1.3.6-SNAPSHOT.
  • Update Jackson to 2.13.4

As part of the issue

sruti1312
sruti1312 previously approved these changes Sep 13, 2022
@zelinh
Copy link
Member

zelinh commented Sep 27, 2022

Hi @sruti1312 , Can we get approval for this PR? Need this for the release.

@sruti1312
Copy link
Contributor

This license file also needs to be changed to 1.3.6.
https://github.com/opensearch-project/performance-analyzer/blob/1.3/licenses/performanceanalyzer-rca-1.3.5.0-SNAPSHOT.jar.sha1

@zelinh
Copy link
Member

zelinh commented Sep 27, 2022

https://github.com/opensearch-project/performance-analyzer/blob/1.3/licenses/performanceanalyzer-rca-1.3.5.0-SNAPSHOT.jar.sha1

Hi Sruti, how could we get and update this file? This was generated after rca gets incremented and built? If so we would need opensearch-project/performance-analyzer-rca#223 to be merged first?

Signed-off-by: opensearch-ci-bot <[email protected]>
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/1.3.6-SNAPSHOT branch from 05f2b35 to 391e8c0 Compare September 29, 2022 00:21
@zelinh
Copy link
Member

zelinh commented Sep 29, 2022

Seems like the bot doesn't allow me to update the license file in this PR. We could do it in another PR?

Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #267 (cd111fd) into 1.3 (0f1e2d5) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #267      +/-   ##
============================================
+ Coverage     72.13%   72.21%   +0.07%     
+ Complexity      357      356       -1     
============================================
  Files            44       44              
  Lines          2519     2519              
  Branches        169      170       +1     
============================================
+ Hits           1817     1819       +2     
+ Misses          597      595       -2     
  Partials        105      105              
Impacted Files Coverage Δ
...nalyzer/collectors/ThreadPoolMetricsCollector.java 90.66% <0.00%> (+2.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon
Copy link
Member

Hi @sruti1312 @sgup432 could you guys help merge this as it is blocking 1.3.6?
Thanks.

@kiranprakash154 kiranprakash154 merged commit 36d85f2 into 1.3 Sep 30, 2022
@kiranprakash154 kiranprakash154 deleted the create-pull-request/1.3.6-SNAPSHOT branch September 30, 2022 23:20
@kiranprakash154 kiranprakash154 changed the title [AUTO] Increment version to 1.3.6-SNAPSHOT [AUTO] Increment version to 1.3.6-SNAPSHOT & Update Jackson Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants