Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] Increment version to 1.3.6-SNAPSHOT & Resolve spotbugs #223

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link

  • Incremented version to 1.3.6-SNAPSHOT.

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team September 9, 2022 19:29
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #223 (b64c12d) into 1.3 (274a8c9) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #223      +/-   ##
============================================
- Coverage     71.65%   71.54%   -0.12%     
+ Complexity     2944     2934      -10     
============================================
  Files           376      376              
  Lines         18838    18778      -60     
  Branches       1465     1437      -28     
============================================
- Hits          13499    13435      -64     
  Misses         4758     4758              
- Partials        581      585       +4     
Impacted Files Coverage Δ
...pensearch/performanceanalyzer/jvm/HeapMetrics.java 40.62% <0.00%> (-15.63%) ⬇️
...nalyzer/rca/net/handler/PublishRequestHandler.java 74.00% <0.00%> (-14.00%) ⬇️
...anceanalyzer/reader/AdmissionControlProcessor.java 72.09% <0.00%> (-2.33%) ⬇️
...ceanalyzer/reader/MasterMetricsEventProcessor.java 88.88% <0.00%> (-1.86%) ⬇️
.../opensearch/performanceanalyzer/jvm/GCMetrics.java 55.88% <0.00%> (-1.48%) ⬇️
...manceanalyzer/rca/persistence/SQLitePersistor.java 75.30% <0.00%> (-0.93%) ⬇️
.../org/opensearch/performanceanalyzer/core/Util.java 70.83% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: opensearch-ci-bot <[email protected]>
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/1.3.6-SNAPSHOT branch from b64c12d to fa303f6 Compare September 20, 2022 00:19
@zelinh
Copy link
Member

zelinh commented Sep 27, 2022

@opensearch-project/performance-analyzer Hi team, can we get approval for this version increment PR? Need this for the release.

sruti1312
sruti1312 previously approved these changes Sep 29, 2022
@zelinh
Copy link
Member

zelinh commented Sep 29, 2022

From what im seeing from the recent PRs pushed into 1.3 branch. The CI failure seems to be a long time issue and it hasn't been resolved so far. https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/3085208307/jobs/4988228084
Therefore, I believe it's not caused by this PR and can we prioritize this to unblock for the release? Thanks.

@kiranprakash154 kiranprakash154 dismissed stale reviews from sruti1312 and themself via 9923e46 September 29, 2022 23:42
Signed-off-by: Kiran Prakash <[email protected]>
@kiranprakash154 kiranprakash154 changed the title [AUTO] Increment version to 1.3.6-SNAPSHOT [AUTO] Increment version to 1.3.6-SNAPSHOT & Resolve spotbugs Sep 29, 2022
.forEach(decision::addAction);
BaseClusterRca baseClusterRcaMap = cacheTypeBaseClusterRcaMap.get(cacheType);
if (baseClusterRcaMap == null)
continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would just need to go to the next cache action in that case right ? if we return, then we no longer loop through the cache action priority list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it would be continue.

.forEach(decision::addAction);
BaseClusterRca baseClusterRcaMap = cacheTypeBaseClusterRcaMap.get(cacheType);
if (baseClusterRcaMap == null)
continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it would be continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants