-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTO] Increment version to 1.3.6-SNAPSHOT & Resolve spotbugs #223
Conversation
opensearch-trigger-bot
bot
commented
Sep 9, 2022
- Incremented version to 1.3.6-SNAPSHOT.
Codecov Report
@@ Coverage Diff @@
## 1.3 #223 +/- ##
============================================
- Coverage 71.65% 71.54% -0.12%
+ Complexity 2944 2934 -10
============================================
Files 376 376
Lines 18838 18778 -60
Branches 1465 1437 -28
============================================
- Hits 13499 13435 -64
Misses 4758 4758
- Partials 581 585 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: opensearch-ci-bot <[email protected]>
b64c12d
to
fa303f6
Compare
@opensearch-project/performance-analyzer Hi team, can we get approval for this version increment PR? Need this for the release. |
From what im seeing from the recent PRs pushed into 1.3 branch. The CI failure seems to be a long time issue and it hasn't been resolved so far. https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/3085208307/jobs/4988228084 |
Signed-off-by: Kiran Prakash <[email protected]>
9923e46
Signed-off-by: Kiran Prakash <[email protected]>
.forEach(decision::addAction); | ||
BaseClusterRca baseClusterRcaMap = cacheTypeBaseClusterRcaMap.get(cacheType); | ||
if (baseClusterRcaMap == null) | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would just need to go to the next cache action in that case right ? if we return, then we no longer loop through the cache action priority list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it would be continue.
.forEach(decision::addAction); | ||
BaseClusterRca baseClusterRcaMap = cacheTypeBaseClusterRcaMap.get(cacheType); | ||
if (baseClusterRcaMap == null) | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it would be continue.