Fix spotbugs failure by removing unused variable. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Handalian <[email protected]>
dblock
approved these changes
Aug 17, 2021
|
We need to get this build to green. Comment out the failing test and open an issue? I see |
|
This check has not passed on PR in two months. The previous run before this had the same tests failing and multiple PRs merged. 669 tests completed, 87 failed I will open an issue to address these unit tests, but I suggest we merge this so at least building without tests succeeds. |
|
I have opened #49 |
sruti1312
approved these changes
Aug 17, 2021
14 tasks
eirsep
pushed a commit
to eirsep/performance-analyzer-rca
that referenced
this pull request
Sep 6, 2021
) Signed-off-by: Marc Handalian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc Handalian [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
This PR fixes the build of main by fixing spotbugs to pass.
This commit removed the usage of this variable but left its declaration, causing spotbugs to fail.
Describe the solution you are proposing
Remove unused variable. Without this change the following fails on main:
This is further causing problems because the performance-analyzer plugin repo always clones and builds main.
closes #46
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.