Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system to build performance-analyzer #148

Closed
Tracked by #212 ...
mch2 opened this issue Aug 6, 2021 · 3 comments · Fixed by #281
Closed
Tracked by #212 ...

Update build system to build performance-analyzer #148

mch2 opened this issue Aug 6, 2021 · 3 comments · Fixed by #281
Assignees
Labels
bug Something isn't working

Comments

@mch2
Copy link
Member

mch2 commented Aug 6, 2021

Currently Performance-analyzer is commented out in the InputManifest for 1.0.

This component should be included with all the others but its build is currently failing if uncommented.

  • This component requires performance-analyzer-rca to also be assembled and included within performance-analyzer-rca.zip. Example of it being required during bundle assembly.
  • This component's snapshot build by passing -Dbuild.snapshot=true needs to work and output -SNAPSHOT artifacts.
@xuezhou25 xuezhou25 self-assigned this Aug 6, 2021
@dblock dblock added the bug Something isn't working label Aug 6, 2021
@xuezhou25
Copy link
Contributor

About this build fail, it is because spotless in RCA(when build PA, it will by default build RCA internal) required two branch to compare(for example main and 1.0).

* What went wrong:
A problem occurred configuring root project 'tmp3gn5llmf'.
> No such reference 'origin/main'

After fix RCA by skip the spotless step, it can build successful.

@mch2
Copy link
Member Author

mch2 commented Aug 17, 2021

RCA is also failing its spotbugs check on main. -> opensearch-project/performance-analyzer-rca#47

We can get by that when building RCA directly, but when we build the main plugin repo it is always cloning and building the main branch of RCA internally as part of its build scripts. opensearch-project/performance-analyzer#45
This means we cannot bypass this step and the build fails.

This means that any build of perf analyzer fails, even for 1.1, until the above PR is merged.

@mch2
Copy link
Member Author

mch2 commented Aug 17, 2021

with the following snippet we can get by the spotless check in build.sh for each repo.

# remove this script when https://github.com/opensearch-project/performance-analyzer/issues/44 is fixed
git fetch origin main
git checkout main
# move back to initial ref
git checkout -

without the spotbugs fix we have no way of producing a successful build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants