-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searchbackpressure Service Reader and UTs added #427
Merged
ansjcy
merged 11 commits into
opensearch-project:main
from
CoderJeffrey:searchbp_deployment
Jul 3, 2023
Merged
Searchbackpressure Service Reader and UTs added #427
ansjcy
merged 11 commits into
opensearch-project:main
from
CoderJeffrey:searchbp_deployment
Jul 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zon.com) Signed-off-by: CoderJeffrey <[email protected]>
CoderJeffrey
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
June 22, 2023 18:30
Signed-off-by: CoderJeffrey <[email protected]>
….com) Signed-off-by: CoderJeffrey <[email protected]>
…amazon.com) Signed-off-by: CoderJeffrey <[email protected]>
…-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]>
5 tasks
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsSnapShot.java
Show resolved
Hide resolved
…-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]>
…[email protected]) Signed-off-by: CoderJeffrey <[email protected]>
khushbr
reviewed
Jun 29, 2023
src/main/java/org/opensearch/performanceanalyzer/reader/MetricsEmitter.java
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/reader/MetricsEmitter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/reader/MetricsEmitter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsSnapShot.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsSnapShot.java
Outdated
Show resolved
Hide resolved
khushbr
reviewed
Jun 29, 2023
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsSnapShot.java
Show resolved
Hide resolved
khushbr
reviewed
Jun 29, 2023
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsSnapShot.java
Show resolved
Hide resolved
…on.com) Signed-off-by: CoderJeffrey <[email protected]>
CoderJeffrey
force-pushed
the
searchbp_deployment
branch
from
June 30, 2023 00:37
dab5350
to
6578073
Compare
ansjcy
previously approved these changes
Jul 3, 2023
khushbr
reviewed
Jul 3, 2023
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsProcessor.java
Outdated
Show resolved
Hide resolved
khushbr
reviewed
Jul 3, 2023
src/main/java/org/opensearch/performanceanalyzer/reader/SearchBackPressureMetricsSnapShot.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
============================================
+ Coverage 75.98% 76.18% +0.19%
- Complexity 2581 2601 +20
============================================
Files 302 304 +2
Lines 15356 15577 +221
Branches 1213 1219 +6
============================================
+ Hits 11669 11867 +198
- Misses 3193 3211 +18
- Partials 494 499 +5
|
…rey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]>
…OC (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]>
…y Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]>
khushbr
approved these changes
Jul 3, 2023
LGTM! Thank you for making this change @CoderJeffrey |
ansjcy
approved these changes
Jul 3, 2023
This was referenced Jul 8, 2023
5 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Remove log files and add DCO (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove extra files (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove styling difference (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove unnecessary file changes (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Use Commons package for metric table naming and column naming (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove unnecessary comments and add more descriptive comments (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove unnecessary global variables (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Add comments and adjust UTs (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove tab space and change avg datatype to LONG (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove tab space and change avg datatype to LONG and additional JAVADOC (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Add description for searchbp stats in sqlitedb (signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> --------- Signed-off-by: CoderJeffrey <[email protected]> (cherry picked from commit 53e3b94)
khushbr
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Remove log files and add DCO (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove extra files (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove styling difference (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove unnecessary file changes (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Use Commons package for metric table naming and column naming (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove unnecessary comments and add more descriptive comments (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove unnecessary global variables (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Add comments and adjust UTs (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove tab space and change avg datatype to LONG (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Remove tab space and change avg datatype to LONG and additional JAVADOC (Signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> * Add description for searchbp stats in sqlitedb (signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]> --------- Signed-off-by: CoderJeffrey <[email protected]> (cherry picked from commit 53e3b94) Co-authored-by: Jeffrey Liu <[email protected]>
71 tasks
khushbr
added a commit
to khushbr/performance-analyzer-rca
that referenced
this pull request
Oct 6, 2023
khushbr
added a commit
that referenced
this pull request
Oct 6, 2023
khushbr
added a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeffrey Liu [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
To fix on issue #424. The PR mainly adds the reader to consume SearchBackPressure Service metrics.
Describe the solution you are proposing
Adds the reader (processor and snapshot) for SearchBackPressureServiceStats and populate the extracted fields into the sqlitedb. Also add the UTs to test both SearchBackPressureMetricsProcessor.java and SearchBackPressureMetricsSnapShot.java.
Describe alternatives you've considered
N/A
Additional context
Parallel PR needs to be approved to pass the Build Test (PR Handling empty flow unit during Cache/Queue RCA execution #34 for the Commons Package) (Constants added for searchbackpressure rca reader to consume searchbackpressure metrics in shared folder performance-analyzer-commons#34). This PR adds the Constants needed by reader to consume metrics in shared folder.
This PR is built upon the changes of the other 2 PR for performance-analyzer and performance-analyzer-commons
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.