SearchbackpressureStatsCollector Constants Added #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeffrey Liu [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The SearchBackpressureStatsCollector.java added in pull & request (opensearch-project/performance-analyzer#483) use literal String value (e.g. "searchbp_nodeid"0 for json field, which is not aligned with instance accessing and coding styles with other collectors.
Describe the solution you are proposing
Added all required Constants needed by SearchbackPressureStatsCollector.java to populate the jsonFields
Example:
@JsonProperty("searchbp_nodeid") public String getSearchBackPressureStats_NodeId() { return this.nodeId; }
Has changed to:
@JsonProperty(SearchBackPressureStatsValue.Constants.SEARCHBP_NODEID) public String getSearchBackPressureStats_NodeId() { return this.nodeId; }
Describe alternatives you've considered
N/A
Additional context
Parallel Pull & Request with opensearch-project/performance-analyzer#483
This Commons Package PR (SearchbackpressureStatsCollector Constants Added #33 ) is needed in order to run the parallel PA-plugin PR.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.