Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchbackpressureStatsCollector Constants Added #33

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

CoderJeffrey
Copy link
Contributor

@CoderJeffrey CoderJeffrey commented Jun 19, 2023

Signed-off-by: Jeffrey Liu [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The SearchBackpressureStatsCollector.java added in pull & request (opensearch-project/performance-analyzer#483) use literal String value (e.g. "searchbp_nodeid"0 for json field, which is not aligned with instance accessing and coding styles with other collectors.

Describe the solution you are proposing
Added all required Constants needed by SearchbackPressureStatsCollector.java to populate the jsonFields

Example:
@JsonProperty("searchbp_nodeid") public String getSearchBackPressureStats_NodeId() { return this.nodeId; }

Has changed to:
@JsonProperty(SearchBackPressureStatsValue.Constants.SEARCHBP_NODEID) public String getSearchBackPressureStats_NodeId() { return this.nodeId; }

Describe alternatives you've considered
N/A

Additional context
Parallel Pull & Request with opensearch-project/performance-analyzer#483
This Commons Package PR (SearchbackpressureStatsCollector Constants Added #33 ) is needed in order to run the parallel PA-plugin PR.

Check List

  • New functionality includes testing.
  • All tests pass
  • New functionality has been documented.
  • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…PressureStatsCollector.java (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>
…or.java for Performance Analyzer Plugin (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>
@sbcd90 sbcd90 merged commit 9c8af69 into opensearch-project:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants