-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Internet Explorer specific code #890
Conversation
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super familiar with playground, but just 1 question about it. Also, may be good to merge after #879 is merged, as we're going to have conflicts anyway, but that one is larger than this one
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change. I would love to revisit browserlist
and get t to match that of OSD's.
Signed-off-by: Miki <[email protected]>
CHANGELOG.md
Outdated
@@ -72,6 +72,7 @@ | |||
|
|||
- [CVE-2023-26136] Add resolution for tough-cookie to ^4.1.3 ([#889](https://github.com/opensearch-project/oui/pull/889)) | |||
- [CVE-2023-26115] Bump word-wrap from 1.2.3 to 1.2.4 ([#891](https://github.com/opensearch-project/oui/pull/891)) | |||
- Remove Internet Explorer specific code ([#890](https://github.com/opensearch-project/oui/pull/890)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to unreleased
section before merging. This is an artifact of how updating the changelog was done, sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Signed-off-by: Josh Romero <[email protected]>
* clean IE from .broswerlistrc (#886) Signed-off-by: Danila Gulderov <[email protected]> * clean IE from react-datepicker(#886) Signed-off-by: Danila Gulderov <[email protected]> * clean IE related (#886) Signed-off-by: Danila Gulderov <[email protected]> * changelog update (#886) Signed-off-by: Danila Gulderov <[email protected]> * changelog update (#886) Signed-off-by: Danila Gulderov <[email protected]> * changelog link fix Signed-off-by: Danila Gulderov <[email protected]> * check for unsupported playground Signed-off-by: Danila Gulderov <[email protected]> * cleanup ie code Signed-off-by: Danila Gulderov <[email protected]> * Changelog update (#886) Signed-off-by: Danila Gulderov <[email protected]> --------- Signed-off-by: Danila Gulderov <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 0d20b45) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* clean IE from .broswerlistrc (#886) Signed-off-by: Danila Gulderov <[email protected]> * clean IE from react-datepicker(#886) Signed-off-by: Danila Gulderov <[email protected]> * clean IE related (#886) Signed-off-by: Danila Gulderov <[email protected]> * changelog update (#886) Signed-off-by: Danila Gulderov <[email protected]> * changelog update (#886) Signed-off-by: Danila Gulderov <[email protected]> * changelog link fix Signed-off-by: Danila Gulderov <[email protected]> * check for unsupported playground Signed-off-by: Danila Gulderov <[email protected]> * cleanup ie code Signed-off-by: Danila Gulderov <[email protected]> * Changelog update (#886) Signed-off-by: Danila Gulderov <[email protected]> --------- Signed-off-by: Danila Gulderov <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 0d20b45) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]>
Description
This pull request cleans the codebase from IE-specific code as described in #886
Issues Resolved
closes #886
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.