Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Internet Explorer specific code #890

Merged
merged 14 commits into from
Oct 16, 2023

Conversation

gulderov
Copy link
Contributor

@gulderov gulderov commented Jul 19, 2023

Description

This pull request cleans the codebase from IE-specific code as described in #886

Issues Resolved

closes #886

Check List

  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with playground, but just 1 question about it. Also, may be good to merge after #879 is merged, as we're going to have conflicts anyway, but that one is larger than this one

src-docs/src/components/guide_section/guide_section.tsx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
gulderov added 3 commits July 21, 2023 11:41
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Danila Gulderov <[email protected]>
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. I would love to revisit browserlist and get t to match that of OSD's.

CHANGELOG.md Outdated
@@ -72,6 +72,7 @@

- [CVE-2023-26136] Add resolution for tough-cookie to ^4.1.3 ([#889](https://github.com/opensearch-project/oui/pull/889))
- [CVE-2023-26115] Bump word-wrap from 1.2.3 to 1.2.4 ([#891](https://github.com/opensearch-project/oui/pull/891))
- Remove Internet Explorer specific code ([#890](https://github.com/opensearch-project/oui/pull/890))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to unreleased section before merging. This is an artifact of how updating the changelog was done, sorry!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gulderov gulderov requested a review from BSFishy September 15, 2023 06:26
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@joshuarrrr joshuarrrr merged commit 0d20b45 into opensearch-project:main Oct 16, 2023
9 of 14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 16, 2023
* clean IE from .broswerlistrc (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE from react-datepicker(#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE related (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog link fix

Signed-off-by: Danila Gulderov <[email protected]>

* check for unsupported playground

Signed-off-by: Danila Gulderov <[email protected]>

* cleanup ie code

Signed-off-by: Danila Gulderov <[email protected]>

* Changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

---------

Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 0d20b45)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr added a commit that referenced this pull request Nov 14, 2023
* clean IE from .broswerlistrc (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE from react-datepicker(#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE related (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog link fix

Signed-off-by: Danila Gulderov <[email protected]>

* check for unsupported playground

Signed-off-by: Danila Gulderov <[email protected]>

* cleanup ie code

Signed-off-by: Danila Gulderov <[email protected]>

* Changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

---------

Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 0d20b45)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Internet Explorer specific code
4 participants