Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Internet Explorer specific code #886

Closed
gulderov opened this issue Jul 13, 2023 · 2 comments · Fixed by #890
Closed

Remove Internet Explorer specific code #886

gulderov opened this issue Jul 13, 2023 · 2 comments · Fixed by #890
Labels
bug Something isn't working

Comments

@gulderov
Copy link
Contributor

Internet Explorer has officially retired and out of support. Given that our .browserslistrc is already set to not dead. It is not longer necessary to include Internet Explorer specific code in codebase

As per Browserslist documentation IE considered 'dead'

Here are the proposed changes:

  • Clean IE from .browserslistrc file
  • Remove browser specific checks like isIE, documentMode, MSInpiutMethodContext
@gulderov gulderov added bug Something isn't working untriaged labels Jul 13, 2023
@gulderov gulderov mentioned this issue Jul 13, 2023
Merged
5 tasks
@joshuarrrr
Copy link
Member

Thanks @gulderov, that seems like a good idea - are you interested in raising the PR for this change?

gulderov added a commit to gulderov/oui that referenced this issue Jul 19, 2023
@gulderov
clean IE from .broswerlistrc (opensearch-project#886)
90ae141 
Signed-off-by: Danila Gulderov <[email protected]>
gulderov added a commit to gulderov/oui that referenced this issue Jul 19, 2023
@gulderov
clean IE from react-datepicker(opensearch-project#886)
39bbc7b 
Signed-off-by: Danila Gulderov <[email protected]>
gulderov added a commit to gulderov/oui that referenced this issue Jul 19, 2023
@gulderov
clean IE related (opensearch-project#886)
4342f3c 
Signed-off-by: Danila Gulderov <[email protected]>
@gulderov
Copy link
Contributor Author

I would be happy to create a pull request to resolve this issue

gulderov added a commit to gulderov/oui that referenced this issue Jul 19, 2023
@gulderov
changelog update (opensearch-project#886)
bafa698 
Signed-off-by: Danila Gulderov <[email protected]>
@gulderov gulderov mentioned this issue Jul 19, 2023
Merged
5 tasks
gulderov added a commit to gulderov/oui that referenced this issue Jul 19, 2023
@gulderov
changelog update (opensearch-project#886)
7d2c615 
Signed-off-by: Danila Gulderov <[email protected]>
gulderov added a commit to gulderov/oui that referenced this issue Sep 15, 2023
@gulderov
Changelog update (opensearch-project#886)
d85249a 
Signed-off-by: Danila Gulderov <[email protected]>
joshuarrrr added a commit that referenced this issue Oct 16, 2023
@gulderov @AMoo-Miki @joshuarrrr
Remove Internet Explorer specific code (#890)
0d20b45 
* clean IE from .broswerlistrc (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE from react-datepicker(#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE related (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog link fix

Signed-off-by: Danila Gulderov <[email protected]>

* check for unsupported playground

Signed-off-by: Danila Gulderov <[email protected]>

* cleanup ie code

Signed-off-by: Danila Gulderov <[email protected]>

* Changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

---------

Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 16, 2023
@github-actions
Remove Internet Explorer specific code (#890)
82fd0f1 
* clean IE from .broswerlistrc (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE from react-datepicker(#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE related (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog link fix

Signed-off-by: Danila Gulderov <[email protected]>

* check for unsupported playground

Signed-off-by: Danila Gulderov <[email protected]>

* cleanup ie code

Signed-off-by: Danila Gulderov <[email protected]>

* Changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

---------

Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 0d20b45)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr added a commit that referenced this issue Nov 14, 2023
@opensearch-trigger-bot @github-actions @joshuarrrr
Remove Internet Explorer specific code (#890) (#1100)
aa3de30 
* clean IE from .broswerlistrc (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE from react-datepicker(#886)

Signed-off-by: Danila Gulderov <[email protected]>

* clean IE related (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

* changelog link fix

Signed-off-by: Danila Gulderov <[email protected]>

* check for unsupported playground

Signed-off-by: Danila Gulderov <[email protected]>

* cleanup ie code

Signed-off-by: Danila Gulderov <[email protected]>

* Changelog update (#886)

Signed-off-by: Danila Gulderov <[email protected]>

---------

Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 0d20b45)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Internet Explorer specific code gulderov/oui
2 participants
@gulderov @joshuarrrr