Remove charts theme code

[SamantaTarun]

Description

Removed the charts folder with two files (theme.scss and themes.ts).

Issues Resolved

#531

Check List

• New functionality includes testing.
• New functionality has been documented.
• All tests pass
  • yarn lint
  • yarn test-unit
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[BSFishy]

Thanks for the contribution! There are a few things that I would like to be completed before we review this PR. Specifically, could the description be filled out, specifically the Description and Issues Resolved sections?

Also, it looks like DCO didn't pass. Do you think you could sign your commit? Related links:

• https://github.com/opensearch-project/oui/blob/main/CONTRIBUTING.md#developer-certificate-of-origin
• https://www.atlassian.com/git/tutorials/rewriting-history

[SergeyMyssak]

Hello @tarunsamanta2k20, in order to merge this PR, you need to do the following steps:

1. In the Description section, write what was done in this PR, for example:

Removed the charts folder with two files (theme.scss and themes.ts).

2. In the Issues Resolved section, simply paste the link to the problem you solved, for example:

#531

3. Run yarn lint and yarn test-unit commands locally with your changes and then select the appropriate checkboxes. To select a checkbox you need to write x inside [], like this [x].
4. You need to change your commit message and re-commit your changes with the --signoff flag, please make sure your GitHub email is public (you can check it in your GitHub settings).

You can copy these commands and run them:

git reset --soft HEAD~1
git commit -m "Remove theme folder for charts" --signoff

After that, you can select the Commits are signed per the DCO using --signoff checkbox.

---

FYI: @tarunsamanta2k20, please don't forget to remove charts folder, I see that there is an empty folder left in the code.

Thanks for contributing!

[SergeyMyssak]

Hello @tarunsamanta2k20, I see that you changed the description of the issue! Well done! Now just need to pass the DCO pipeline. Please try to run these commands:

git reset --soft HEAD~1
git commit -m "Remove theme folder for charts" --signoff

And don't forget to push this updated commit to your branch:

git push origin tarun_samanta/#531 --force

Just a little bit left! Thanks for your changes!

[SamantaTarun]

Hello @tarunsamanta2k20, I see that you changed the description of the issue! Well done! Now just need to pass the DCO pipeline. Please try to run these commands:

git reset --soft HEAD~1
git commit -m "Remove theme folder for charts" --signoff

And don't forget to push this updated commit to your branch:

git push origin tarun_samanta/#531 --force

Just a little bit left! Thanks for your changes!

@BSFishy done!

[joshuarrrr]

@tarunsamanta2k20 The linter check is failing because there's still a reference to one of the deleted files that needs to be removed: https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/markdown_editor/markdown_editor_with_plugins.js#L22

and
https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/markdown_editor/markdown_editor_with_plugins.js#L251

[SamantaTarun]

@joshuarrrr let me check once.

[SamantaTarun]

@tarunsamanta2k20 The linter check is failing because there's still a reference to one of the deleted files that needs to be removed: https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/markdown_editor/markdown_editor_with_plugins.js#L22

and https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/markdown_editor/markdown_editor_with_plugins.js#L251

@joshuarrrr let me check once.

[SamantaTarun]

@joshuarrrr shall I remove entire block of code under those imports?

[joshuarrrr]

Yeah, remove the import on L22 and on L251, remove that entry from the array.

[SamantaTarun]

@joshuarrrr Let me check once.

[BSFishy]

LGTM

[joshuarrrr]

@BSFishy Does this need to be backported?

[BSFishy]

@BSFishy Does this need to be backported?

This is breaking. No backport needed. (Also of note, I'm pretty sure this is incompatible with Dashboards)

[SamantaTarun]

@BSFishy please follow me on GITHUB.