Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes to chart themes #810

Closed
joshuarrrr opened this issue Jun 14, 2023 · 3 comments
Closed

Revert changes to chart themes #810

joshuarrrr opened this issue Jun 14, 2023 · 3 comments

Comments

@joshuarrrr
Copy link
Member

2086980 and e9a63af need to be reverted in main, which break integrations with OpenSearch Dashboards.
@joshuarrrr joshuarrrr mentioned this issue Jun 14, 2023
Open
11 tasks
@BSFishy BSFishy removed the untriaged label Jun 14, 2023
andreymyssak added a commit to andreymyssak/oui that referenced this issue Jun 20, 2023
@andreymyssak @SergeyMyssak
Update i18ntokens.json (opensearch-project#810)
fcf74bc 
Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>
@andreymyssak andreymyssak mentioned this issue Jun 20, 2023
Merged
6 tasks
andreymyssak added a commit to andreymyssak/oui that referenced this issue Jun 20, 2023
@andreymyssak @SergeyMyssak
Update i18ntokens.json (opensearch-project#810)
1c44f3d 
Signed-off-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
@AMoo-Miki
Copy link
Collaborator

@joshuarrrr how about 1.x?

@joshuarrrr
Copy link
Member Author

Yeah, assuming the original changes were ported to 1.x. I've tagged #831 with a backport 1.x label.

@joshuarrrr
Copy link
Member Author

@AMoo-Miki @andreymyssak Double-check my work here, but I believe the changes in #554 and #657 were never backported, so this can be marked as complete now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuarrrr @AMoo-Miki @BSFishy