[Backport-1.x] fix: Updates to v9 colors, button/input styles, and typography (#1373) #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-project#1373) * fix: Updates to v9 colors, button/input styles, and typography --------- Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 1e69cc8)
virajsanghvi
changed the title
virajsanghvi
requested review from
AMoo-Miki,
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
virajsanghvi
changed the base branch from
backport/backport-1373-to-1.x
to
1.x
bandinib-amzn
approved these changes
Aug 27, 2024
ashwin-pc
approved these changes
Aug 27, 2024
Comment on lines
-50
to
-55
| $ouiColorPrimaryText: makeHighContrastColor($ouiColorPrimary); | ||
| $ouiColorSecondaryText: makeHighContrastColor($ouiColorSecondary); | ||
| $ouiColorAccentText: makeHighContrastColor($ouiColorAccent); | ||
| $ouiColorWarningText: makeHighContrastColor($ouiColorWarning); | ||
| $ouiColorDangerText: makeHighContrastColor($ouiColorDanger); | ||
| $ouiColorDisabledText: makeDisabledContrastColor($ouiColorDisabled); |
There was a problem hiding this comment.
Nit: Any reason we didnt want to reuse these helper functions?
There was a problem hiding this comment.
Mostly because design wanted to choose their own colors for these - not sure anyone understands the color system enough to necessitate using them in this particular case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1373 to 1.x + update to package.json and Changelog for new oui version
Issues Resolved
N/A
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.