-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updates to v9 colors, button/input styles, and typography #1373
Merged
virajsanghvi
merged 4 commits into
opensearch-project:main
from
virajsanghvi:v9-updates
Aug 27, 2024
Merged
fix: Updates to v9 colors, button/input styles, and typography #1373
virajsanghvi
merged 4 commits into
opensearch-project:main
from
virajsanghvi:v9-updates
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajsanghvi
requested review from
AMoo-Miki,
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
August 26, 2024 22:40
Signed-off-by: Viraj Sanghvi <[email protected]>
Signed-off-by: Viraj Sanghvi <[email protected]>
Signed-off-by: Viraj Sanghvi <[email protected]>
bandinib-amzn
force-pushed
the
v9-updates
branch
from
August 26, 2024 23:12
031d902
to
79a6aea
Compare
zhongnansu
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Viraj Sanghvi <[email protected]>
bandinib-amzn
approved these changes
Aug 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
* fix: Updates to v9 colors, button/input styles, and typography --------- Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 1e69cc8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
virajsanghvi
added a commit
to virajsanghvi/oui
that referenced
this pull request
Aug 27, 2024
…earch-project#1373) * fix: Updates to v9 colors, button/input styles, and typography --------- Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 1e69cc8)
7 tasks
virajsanghvi
added a commit
that referenced
this pull request
Aug 27, 2024
#1377) * fix: Updates to v9 colors, button/input styles, and typography --------- Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 1e69cc8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes updates to the v9 theme, including:
Issues Resolved
N/A
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.