Fixes combobox height with appendees #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
|
The OSD ciGroup4 failure is related to a previous PR on switch color changes. #1332 |
ps48
requested review from
AMoo-Miki,
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak,
SergeyMyssak and
virajsanghvi
as code owners
virajsanghvi
reviewed
Aug 8, 2024
| // Overrides line-height of 16px coming from ouiFormControlLayout--group .ouiText | ||
| .ouiFormControlLayout--group .ouiText { | ||
| // sass-lint:disable-block no-important | ||
| line-height: 0 !important; |
There was a problem hiding this comment.
Is it possible to avoid !important with specificity of selectors? Or are there too many to make that worthwhile?
There was a problem hiding this comment.
Even I wasn't happy on this one, I was banking on specificity as these are added under combo box class but then this was necessary as the one I'm overriding had important added to it.
virajsanghvi
approved these changes
Aug 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
--------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit f704404) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 16, 2024
--------- (cherry picked from commit f704404) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the height of combo box with appended items. Whenever an append flag is added to single select combo box, the element height increases from 40px to 42px or even 43.33px based on the type of the item appended. This PR keeps the height of all combo box variants to 40px
Issues Resolved
Prior to fix:
Regular combo box
Combo box with an append item
Combo box with OUIText element as append item
Post fix all the combo boxes are on same height of 40px (non compressed) and 32px (compressed)
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.