Add display type and color to OuiSwitch #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak,
SergeyMyssak and
virajsanghvi
as code owners
AMoo-Miki
force-pushed
the
base-switch
branch
3 times, most recently
from
ae06f30 to
65a4467
Compare
AMoo-Miki
force-pushed
the
base-switch
branch
2 times, most recently
from
ed4dd40 to
f3efd92
Compare
|
OSD failure is expected. |
virajsanghvi
reviewed
Aug 5, 2024
| vertical-align: middle; | ||
| align-items: stretch; | ||
| border-radius: $ouiBorderRadius; | ||
| padding: 0 $euiSize - $euiSizeXS; |
There was a problem hiding this comment.
should we be using ouiSize* here?
| { | ||
| 'ouiSwitch--compressed': compressed, | ||
| 'ouiSwitch-isDisabled': disabled, |
There was a problem hiding this comment.
OUI has some logic which is not clear to me for using -- and -. However, for isDIsabled they have used only one - consistently. Maybe - for state and -- is for variant? Donno.
Signed-off-by: Miki <[email protected]>
virajsanghvi
approved these changes
Aug 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Miki <[email protected]> (cherry picked from commit 1f67bce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Miki <[email protected]> (cherry picked from commit 1f67bce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add display type and color to OuiSwitch
colormakes OuiSwitch colorable like OuiButtondisplayallows showing a border around the switch like OuiButtonIconCheck List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.