Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tree view expanded view #1118 #1134

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

keskami
Copy link
Contributor

@keskami keskami commented Oct 31, 2023

Description

Removes max height for Oui TreeView node

Issues Resolved

Fixes #1118

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: keskami <[email protected]>
@joshuarrrr
Copy link
Member

@keskami Can you add before and after screenshots or videos?

@keskami
Copy link
Contributor Author

keskami commented Nov 8, 2023

Before: children components of TreeView node overflow outside of the TreeView component
Screen Shot 2023-11-08 at 10 12 19 AM

@keskami
Copy link
Contributor Author

keskami commented Nov 8, 2023

After: same child components as before but children components don't overflow outside TreeView component.
Screen Shot 2023-11-08 at 10 14 39 AM

@ashwin-pc ashwin-pc merged commit 351046d into opensearch-project:main Dec 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tree view expanded view
4 participants