Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tree view expanded view #1118

Closed
ps48 opened this issue Oct 28, 2023 · 1 comment · Fixed by #1134
Closed

[BUG] Tree view expanded view #1118

ps48 opened this issue Oct 28, 2023 · 1 comment · Fixed by #1134
Assignees
Labels
bug Something isn't working

Comments

@ps48
Copy link
Member

ps48 commented Oct 28, 2023

Describe the bug
The current implementation of tree view expanded node has a limit in height of 100vh. This is an issue when the children of the a tree node take more then 100vh of space. The next tree nodes overlap content on UI. In our implementation we use overflow property to make the tree view scrollable and removed the max height limit.

To Reproduce
Steps to reproduce the behavior:

  1. Take a sample snippet from https://oui.opensearch.org/1.3/#/navigation/tree-view
  2. Load a tree view node with values that take more than 100vh space when expanded

Probable solutions

  1. Oui can have a the limit override option as props.
  2. Oui can mention the limit as a note in the website so that users know the limitation.

For our use-case, removing max-height limit worked:

.workbench-tree {
  .euiTreeView__node--expanded {
    max-height: none !important;
  }
}

Screenshots
Screenshot 2023-10-27 at 6 12 59 PM

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OUI Version: 1.3
  • OSD Version (if applicable): 2.11
  • OS: 2.11

Additional context

Add any other context about the problem here.

@ps48 ps48 added bug Something isn't working untriaged labels Oct 28, 2023
@keskami
Copy link
Contributor

keskami commented Oct 29, 2023

ill take this issue

keskami added a commit to keskami/oui that referenced this issue Oct 31, 2023
keskami added a commit to keskami/oui that referenced this issue Oct 31, 2023
@BSFishy BSFishy removed the untriaged label Nov 2, 2023
keskami added a commit to keskami/oui that referenced this issue Nov 3, 2023
ashwin-pc pushed a commit that referenced this issue Dec 12, 2023
* Treeview #1118

Signed-off-by: keskami <[email protected]>

* revert

Signed-off-by: keskami <[email protected]>

* [BUG] Tree view expanded view #1118

Signed-off-by: keskami <[email protected]>

* CHANGELOG updated

Signed-off-by: keskami <[email protected]>

---------

Signed-off-by: keskami <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants