Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(OUI Docs) Remove Elastic References from OuiBasicTable Actions examples #697

Closed
5 tasks
KrooshalUX opened this issue Apr 12, 2023 · 3 comments
Closed
5 tasks

(OUI Docs) Remove Elastic References from OuiBasicTable Actions examples #697

KrooshalUX opened this issue Apr 12, 2023 · 3 comments
Labels
OUIDocs

Comments

@KrooshalUX
Copy link
Contributor

Section: "Adding actions to table"

In default example, on all rows:

Then, toggle the option for "multiple actions" example , on all rows:
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this issue Apr 18, 2023
@SergeyMyssak @andreymyssak
Remove Elastic References from OuiBasicTable (opensearch-project#697)
4c15190 
Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>
@SergeyMyssak SergeyMyssak mentioned this issue Apr 18, 2023
Merged
6 tasks
@SergeyMyssak
Copy link
Collaborator

Hello @KrooshalUX, this issue is partially fixed, we just need to backport #623. As a result, we do not have this problem on the main branch:

Screenshot 2023-04-18 at 08 31 45

I raised another PR - #721 to fix the link in a single action.

@SergeyMyssak SergeyMyssak mentioned this issue Apr 19, 2023
Merged
rednaksi91 pushed a commit that referenced this issue May 2, 2023
@SergeyMyssak @andreymyssak
Remove Elastic References from OuiBasicTable (#697) (#721)
d5f6fa6 
Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 2, 2023
@github-actions @andreymyssak
Remove Elastic References from OuiBasicTable (#697) (#721)
45e921c 
Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
(cherry picked from commit d5f6fa6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@SergeyMyssak
Copy link
Collaborator

On version 1.0 everything works as it should:

Screenshot 2023-05-10 at 09 50 07 Screenshot 2023-05-10 at 09 50 28

On version 1.1 there are no changes related to the link in a single action (#721):

Screenshot 2023-05-10 at 09 54 19 Screenshot 2023-05-10 at 09 55 56

ashwin-pc pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions @andreymyssak
Remove Elastic References from OuiBasicTable (#697) (#721) (#744)
2a9f1ae 
(cherry picked from commit d5f6fa6)

Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Myssak <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 20, 2023
@github-actions @andreymyssak
Remove Elastic References from OuiBasicTable (#697) (#721)
b073ee6 
Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
(cherry picked from commit d5f6fa6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@SergeyMyssak SergeyMyssak mentioned this issue Jun 20, 2023
Merged
BSFishy pushed a commit that referenced this issue Jun 20, 2023
@opensearch-trigger-bot @github-actions @andreymyssak
Remove Elastic References from OuiBasicTable (#697) (#721) (#833)
3142c83 
(cherry picked from commit d5f6fa6)

Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Myssak <[email protected]>
@SergeyMyssak
Copy link
Collaborator

On versions 1.0, 1.1, and 1.2 everything works as it should. For 1.1 version the necessary changes were backported and applied.
Screenshot 2023-06-21 at 12 28 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OUIDocs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SergeyMyssak @KrooshalUX