Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Remove Elastic References from OuiBasicTable #721

Conversation

SergeyMyssak
Copy link
Collaborator

Description

Removed Elastic References from OuiBasicTable Actions examples

Screenshot 2023-04-18 at 08 31 33

Issues Resolved

#697

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bandinib-amzn
Copy link
Member

Hi @SergeyMyssak,

Thanks for the change.

Is this PR remove the Elastic References from Actions when toggle the option for "multiple actions" (Please see screen-shot below)?
Screenshot 2023-05-01 at 4 05 52 PM

Can you please attach that screenshot as well?

@bandinib-amzn
Copy link
Member

Pulled this down and works as expected. LGTM!

No Elastic references found on Actions when toggle the option for "multiple actions"

@rednaksi91 rednaksi91 merged commit d5f6fa6 into opensearch-project:main May 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 2, 2023
Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
(cherry picked from commit d5f6fa6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request May 25, 2023
(cherry picked from commit d5f6fa6)

Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Myssak <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 20, 2023
Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
(cherry picked from commit d5f6fa6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy pushed a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit d5f6fa6)

Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Myssak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.1 CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants