Implement Action dependency injection #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #466 +/- ##
============================================
+ Coverage 62.16% 65.92% +3.76%
- Complexity 158 180 +22
============================================
Files 30 35 +5
Lines 740 807 +67
Branches 21 24 +3
============================================
+ Hits 460 532 +72
+ Misses 270 264 -6
- Partials 10 11 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
ryanbogan
approved these changes
Feb 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* ActionModule with getActions method Signed-off-by: Daniel Widdis <[email protected]> * Implement getActionFilters extension point Signed-off-by: Daniel Widdis <[email protected]> * Inject getActions and populate TransportActions Signed-off-by: Daniel Widdis <[email protected]> * Add Sample Actions and fix broken tests Signed-off-by: Daniel Widdis <[email protected]> * Add tests Signed-off-by: Daniel Widdis <[email protected]> * Undo whitespace changes to minimize diff Signed-off-by: Daniel Widdis <[email protected]> * Refactor TransportActions initialization Signed-off-by: Daniel Widdis <[email protected]> * Add test coverage for unregistered action Signed-off-by: Daniel Widdis <[email protected]> * Update migration guide Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 7883fba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
reviewed
Feb 20, 2023
dbwiddis
pushed a commit
that referenced
this pull request
Feb 20, 2023
* ActionModule with getActions method * Implement getActionFilters extension point * Inject getActions and populate TransportActions * Add Sample Actions and fix broken tests * Add tests * Undo whitespace changes to minimize diff * Refactor TransportActions initialization * Add test coverage for unregistered action * Update migration guide --------- (cherry picked from commit 7883fba) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Reviewed the PR. Great Job Dan @dbwiddis . |
This was referenced Feb 21, 2023
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* ActionModule with getActions method Signed-off-by: Daniel Widdis <[email protected]> * Implement getActionFilters extension point Signed-off-by: Daniel Widdis <[email protected]> * Inject getActions and populate TransportActions Signed-off-by: Daniel Widdis <[email protected]> * Add Sample Actions and fix broken tests Signed-off-by: Daniel Widdis <[email protected]> * Add tests Signed-off-by: Daniel Widdis <[email protected]> * Undo whitespace changes to minimize diff Signed-off-by: Daniel Widdis <[email protected]> * Refactor TransportActions initialization Signed-off-by: Daniel Widdis <[email protected]> * Add test coverage for unregistered action Signed-off-by: Daniel Widdis <[email protected]> * Update migration guide Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fully implements
getActions()extension pointclient.execute(action, request, listener)syntax via SDKClientTransportActionsobject on the extensions runner using the expected map typesIssues Resolved
Fixes #368
Fixes #283
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.