Skip to content

Commit

Permalink
Update migration guide
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Widdis <[email protected]>
  • Loading branch information
dbwiddis committed Feb 19, 2023
1 parent 5dc3a9c commit 319e48e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions PLUGIN_MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,9 @@ The [Java Client for OpenSearch](https://github.com/opensearch-project/opensearc
The `SDKRestClient` provides wrapper methods matching the `Client` API (but not implementing it), implemented internally with the (soon to be deprecated) `RestHighLevelClient`. While this speeds migration efforts, it should be considered a temporary "bridge" with follow up migration efforts to the `OpenSearchClient` planned.
- While the class names and method parameters are the same, the `Request` and `Response` classes are often in different packages. In most cases, other than changing `import` statements, no additional code changes are required. In a few cases, there are minor changes required to interface with the new response class API.

The `client.execute(action, request, responseListener)` method is not yet implemented. Instead:
- Instantiate an instance of the corresponding transport action
- Pass the `request` and `responseListener` to the action's `doExecute()` method.
The `client.execute(action, request, responseListener)` method is implemented on the SDKClient.

Remove the transport action inheritance from HandledTransportAction. This may change to direct inheritance of `TransportAction` and implementation of `execute()`.
Change the transport action inheritance from HandledTransportAction to directly inherit from `TransportAction`.

### Replace RestHandler with ExtensionRestHandler

Expand Down

0 comments on commit 319e48e

Please sign in to comment.