Integrated generated dangling_indices client APIs into the existing module #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal and
florianvazelle
as code owners
saimedhi
force-pushed
the
merge/dangling_indices
branch
from
0dec59d to
3512ee1
Compare
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
=======================================
Coverage 70.87% 70.87%
=======================================
Files 83 83
Lines 7790 7790
=======================================
Hits 5521 5521
Misses 2269 2269
|
VachaShah
reviewed
Sep 28, 2023
| the dangling index. | ||
| :arg cluster_manager_timeout: Operation timeout for connection | ||
| to cluster-manager node. | ||
| :arg master_timeout: Operation timeout for connection to master |
There was a problem hiding this comment.
Similar comment for master_timeout comments to mention that it is deprecated. I think it applies to the other generated code PRs.
…odule, ensuring alignment with the server and maintaining backward compatibility Signed-off-by: saimedhi <[email protected]>
saimedhi
force-pushed
the
merge/dangling_indices
branch
from
3512ee1 to
febb5c0
Compare
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
dblock
reviewed
Oct 3, 2023
| @@ -8,6 +8,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Changed | |||
| - Integrated generated `tasks client` APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility ([#508](https://github.com/opensearch-project/opensearch-py/pull/508)) | |||
| - Integrated generated `ingest client` APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility ([#513](https://github.com/opensearch-project/opensearch-py/pull/513)) | |||
| - Integrated generated `dangling_indices client` APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility ([#511](https://github.com/opensearch-project/opensearch-py/pull/511)) | |||
There was a problem hiding this comment.
As a nit, I find these changelogs a bit strange. I think what we're trying to say is that now these parts are geberated code? So maybe "Generate dangling_indices client from API specs"?
dblock
approved these changes
Oct 3, 2023
Merged
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…odule, ensuring alignment with the server and maintaining backward compatibility (opensearch-project#511) Signed-off-by: saimedhi <[email protected]> Signed-off-by: Sai Medhini Reddy Maryada <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrated generated dangling_indices client APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility
Issues Resolved
Related to #477
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.