Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Generated tests for generated code #521

Open
VachaShah opened this issue Oct 3, 2023 · 6 comments
Open

[FEATURE] Generated tests for generated code #521

VachaShah opened this issue Oct 3, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@VachaShah
Copy link
Collaborator

Coming from #511 (review), as @dblock suggested, we should have tests for all the generated code we are putting in, starting with some basic tests that are also generated.

@VachaShah VachaShah added enhancement New feature or request untriaged Need triage labels Oct 3, 2023
@saimedhi
Copy link
Collaborator

saimedhi commented Oct 3, 2023

@saimedhi saimedhi removed the untriaged Need triage label Oct 3, 2023
@VachaShah
Copy link
Collaborator Author

@saimedhi Can we generate some tests from this?

@saimedhi
Copy link
Collaborator

saimedhi commented Oct 3, 2023

The YAML test runner generates tests based on the spec https://github.com/saimedhi/OpenSearch/tree/main/rest-api-spec/src/main/resources/rest-api-spec/test
These tests are stored temporarily and won't be saved. While I'm not certain if these tests can be displayed in clients, they are running and can be utilized.

@dblock
Copy link
Member

dblock commented Oct 4, 2023

I think some unit tests wouldn't hurt either.

@dblock
Copy link
Member

dblock commented Nov 10, 2023

@saimedhi Are we generating with the recent changes when a new API is added? If we do we can close this.

@saimedhi
Copy link
Collaborator

Currently tests are not generated. This needs to be done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants