#284: Add support for connectors #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kalyan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 91.42% 91.47% +0.05%
==========================================
Files 40 41 +1
Lines 4339 4365 +26
==========================================
+ Hits 3967 3993 +26
Misses 372 372 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kalyan <[email protected]>
Signed-off-by: kalyan <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyan <[email protected]>
Signed-off-by: kalyan <[email protected]>
Signed-off-by: kalyan <[email protected]>
Signed-off-by: kalyan <[email protected]>
Signed-off-by: kalyan <[email protected]>
rawwar
requested review from
dhrubo-os,
greaa-aws,
ylwu-amzn,
b4sjoo,
jngz-es and
rbhavna
as code owners
Signed-off-by: kalyan <[email protected]>
dhrubo-os
reviewed
Dec 5, 2023
@dhrubo-os , you can see the comment saying all lines are covered with tests |
rawwar
commented
Dec 6, 2023
|
Oh yeah, sorry I missed that. Approving. Thanks. |
dhrubo-os
approved these changes
Dec 6, 2023
b4sjoo
approved these changes
Dec 6, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Connectors
Issues Resolved
Closes #284
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.