Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for ML Extensibility #284

Closed
dtaivpp opened this issue Sep 15, 2023 · 7 comments · Fixed by #345
Closed

[FEATURE] Support for ML Extensibility #284

dtaivpp opened this issue Sep 15, 2023 · 7 comments · Fixed by #345
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dtaivpp
Copy link
Contributor

dtaivpp commented Sep 15, 2023

Is your feature request related to a problem?
At the moment it does not seem like we have API support for the ML Extensions as documented here: https://opensearch.org/docs/latest/ml-commons-plugin/extensibility/index/

What solution would you like?
I think we should provide support for these API's:

  • Create external connector
  • Create local connector/model

What alternatives have you considered?
N/A

Do you have any additional context?
The API's are well documented so should be as straigforward as replicating what was done with other endpoints.

@dtaivpp dtaivpp added enhancement New feature or request untriaged labels Sep 15, 2023
@dhrubo-os dhrubo-os added good first issue Good for newcomers and removed untriaged labels Sep 17, 2023
@Vinay-Vinod
Copy link
Contributor

Can I be assigned to this issue?

@dhrubo-os
Copy link
Collaborator

Sure, assigning you to the issue.

@dtaivpp
Copy link
Contributor Author

dtaivpp commented Oct 18, 2023

@Vinay-Vinod Can we support the following endpoints for this? Here is the documentation that currently exists for ML connectors:

https://opensearch.org/docs/latest/ml-commons-plugin/extensibility/index/#step-2-create-a-connector

connection.ml_connector.create()
connection.ml_connector.delete()
connection.ml_connector.list()
connection.ml_connector.search()

@rawwar
Copy link
Contributor

rawwar commented Nov 24, 2023

@dhrubo-os , can you assign me this issue. I'll be working on this one

@dhrubo-os dhrubo-os assigned rawwar and unassigned Vinay-Vinod Nov 24, 2023
@dhrubo-os
Copy link
Collaborator

@rawwar Thanks, assigned it to you.

@rawwar
Copy link
Contributor

rawwar commented Nov 24, 2023

@dtaivpp, @dhrubo-os , Internal connectors are actually created by invoking model register endpoint. So, Do we want to have a separate method in the opensearch-py-ml that does it? Internally, it would be just calling model register. But, this create_internal_connector can act as a helper method.

Also, I think adding support for registering supported connectors, can be really useful. what do you think?

@dhrubo-os
Copy link
Collaborator

We don't need any separate method for internal connector. We need to corresponding functions for the api endpoints ml-commons have. So create/update/delete/search/get connectors should be fine.

dhrubo-os pushed a commit that referenced this issue Dec 6, 2023
* add connectors

Signed-off-by: kalyan <[email protected]>

* update

Signed-off-by: kalyan <[email protected]>

* fix

Signed-off-by: kalyan <[email protected]>

* rename

Signed-off-by: kalyanr <[email protected]>

* add tests

Signed-off-by: kalyan <[email protected]>

* fix

Signed-off-by: kalyan <[email protected]>

* fix

Signed-off-by: kalyan <[email protected]>

* lint fix

Signed-off-by: kalyan <[email protected]>

* update changelog

Signed-off-by: kalyan <[email protected]>

* increase test coverage

Signed-off-by: kalyan <[email protected]>

---------

Signed-off-by: kalyan <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants