-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support for ML Extensibility #284
Comments
Can I be assigned to this issue? |
Sure, assigning you to the issue. |
@Vinay-Vinod Can we support the following endpoints for this? Here is the documentation that currently exists for ML connectors: https://opensearch.org/docs/latest/ml-commons-plugin/extensibility/index/#step-2-create-a-connector
|
@dhrubo-os , can you assign me this issue. I'll be working on this one |
@rawwar Thanks, assigned it to you. |
@dtaivpp, @dhrubo-os , Internal connectors are actually created by invoking model register endpoint. So, Do we want to have a separate method in the opensearch-py-ml that does it? Internally, it would be just calling model register. But, this Also, I think adding support for registering supported connectors, can be really useful. what do you think? |
We don't need any separate method for internal connector. We need to corresponding functions for the api endpoints ml-commons have. So create/update/delete/search/get connectors should be fine. |
* add connectors Signed-off-by: kalyan <[email protected]> * update Signed-off-by: kalyan <[email protected]> * fix Signed-off-by: kalyan <[email protected]> * rename Signed-off-by: kalyanr <[email protected]> * add tests Signed-off-by: kalyan <[email protected]> * fix Signed-off-by: kalyan <[email protected]> * fix Signed-off-by: kalyan <[email protected]> * lint fix Signed-off-by: kalyan <[email protected]> * update changelog Signed-off-by: kalyan <[email protected]> * increase test coverage Signed-off-by: kalyan <[email protected]> --------- Signed-off-by: kalyan <[email protected]> Signed-off-by: kalyanr <[email protected]>
Is your feature request related to a problem?
At the moment it does not seem like we have API support for the ML Extensions as documented here: https://opensearch.org/docs/latest/ml-commons-plugin/extensibility/index/
What solution would you like?
I think we should provide support for these API's:
What alternatives have you considered?
N/A
Do you have any additional context?
The API's are well documented so should be as straigforward as replicating what was done with other endpoints.
The text was updated successfully, but these errors were encountered: