Add Client factories for Guzzle and Symfony #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpepper
requested review from
VachaShah,
dblock,
harshavamsi,
shyim and
saimedhi
as code owners
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
client-factories
branch
from
a18f79b to
80321ad
Compare
shyim
approved these changes
Feb 6, 2025
dblock
reviewed
Feb 6, 2025
| @@ -4,6 +4,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
|
|
|||
| ## [Unreleased] | |||
| ### Added | |||
| - Added Guzzle and Symfony client factories. | |||
There was a problem hiding this comment.
Added missing PR numbers in #290.
| @@ -16,95 +16,50 @@ openseach-php removes the hard-coded dependency on the [Guzzle HTTP client](http | |||
|
|
|||
| You can continue to use Guzzle, but will need to configure it as a PSR-18 HTTP Client. | |||
|
|
|||
| ### HTTP Client Auto-Discovery | |||
| ### PSR-18 HTTP Client Interfaces | |||
There was a problem hiding this comment.
The TOC needed an update, did in #290.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#271 Added HTTP Client factories. This PR adds OpenSearch\Client. factories to simplify client creation.
It also:
base_uriusing that methodIssues Resolved
#257
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.