Adds http client factories #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpepper
requested review from
VachaShah,
dblock,
harshavamsi,
shyim and
saimedhi
as code owners
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
client-builder
branch
from
c6c491d to
7d2e06b
Compare
shyim
reviewed
Jan 28, 2025
dblock
reviewed
Jan 28, 2025
|
Rebase after #272. |
kimpepper
force-pushed
the
client-builder
branch
2 times, most recently
from
1267d71 to
fd1adb5
Compare
kimpepper
commented
Jan 29, 2025
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
client-builder
branch
from
fd1adb5 to
50d2f03
Compare
|
We should update the docs to use these. |
I'll merge, but do open an issue to remember to do it at least. |
dblock
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds http client factories with some useful default configuration to simplify http client creation.
Issues Resolved
#257
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.