Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release drafter permissions #913

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Aug 23, 2024

Description

Update release drafter permission with content: write to submit releases as specified in https://github.com/softprops/action-gh-release?tab=readme-ov-file#permissions

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

N/A, verified through documentation

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.60%. Comparing base (143ce1a) to head (8046d2e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #913      +/-   ##
============================================
+ Coverage     74.55%   74.60%   +0.04%     
- Complexity     1964     1966       +2     
============================================
  Files           343      343              
  Lines         13552    13552              
  Branches        786      786              
============================================
+ Hits          10104    10110       +6     
+ Misses         2960     2953       -7     
- Partials        488      489       +1     
Flag Coverage Δ
gradle-test 69.11% <ø> (+0.06%) ⬆️
python-test 88.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied
Copy link
Member

@AndreKurait could you provide the 'why do we need this change'? What isn't work without this write permission.

@AndreKurait
Copy link
Member Author

AndreKurait commented Aug 23, 2024

@AndreKurait could you provide the 'why do we need this change'? What isn't work without this write permission.

@peternied, changed "release" to "publish a release" in the "Why these changes are required". Let me know if that makes sense. This is the API action equivalent of clicking "publish release" in the UI below

image

@AndreKurait AndreKurait merged commit 8d5c6bc into opensearch-project:main Aug 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants