-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Release Drafter and Jenkinsfile with Docker credentials and promotions #860
Update Release Drafter and Jenkinsfile with Docker credentials and promotions #860
Conversation
…omotions Signed-off-by: Peter Zhu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
============================================
+ Coverage 74.31% 74.38% +0.07%
- Complexity 1869 1870 +1
============================================
Files 330 330
Lines 13010 13024 +14
Branches 740 740
============================================
+ Hits 9668 9688 +20
+ Misses 2866 2861 -5
+ Partials 476 475 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Nied <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @peterzhuamazon overall approach looks good, but I'd prefer if we can reduce the redundant build job definitions seems easy for a copypasta error to be hidden in there.
Maybe this PR [1] could do that - or let me know what your think about this.
Refactor docker copy into a more streamline script
Co-authored-by: Andre Kurait <[email protected]> Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon Thanks for this change, we will merge as soon as CI passes - have a great weekend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's hold off merging until @sumobrian chimes in and we have bandwidth to test this without blocking a necessary release
Release worked today, will merge to test this
Description
Update Release Drafter and Jenkinsfile with Docker credentials and promotions
Issues Resolved
Closes opensearch-project/opensearch-build#4857
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.