Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Drafter and Jenkinsfile with Docker credentials and promotions #860

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Update Release Drafter and Jenkinsfile with Docker credentials and promotions

Issues Resolved

Closes opensearch-project/opensearch-build#4857

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added the enhancement New feature or request label Aug 2, 2024
@peterzhuamazon peterzhuamazon self-assigned this Aug 2, 2024
@peterzhuamazon peterzhuamazon added infrastructure migrations and upgrades Used for Issues and Pull Requests related to OpenSearch upgrades and migrations release labels Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.38%. Comparing base (abe067c) to head (4f44062).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #860      +/-   ##
============================================
+ Coverage     74.31%   74.38%   +0.07%     
- Complexity     1869     1870       +1     
============================================
  Files           330      330              
  Lines         13010    13024      +14     
  Branches        740      740              
============================================
+ Hits           9668     9688      +20     
+ Misses         2866     2861       -5     
+ Partials        476      475       -1     
Flag Coverage Δ
gradle-test 68.70% <ø> (+0.06%) ⬆️
python-test 88.43% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @peterzhuamazon overall approach looks good, but I'd prefer if we can reduce the redundant build job definitions seems easy for a copypasta error to be hidden in there.

Maybe this PR [1] could do that - or let me know what your think about this.

jenkins/release.jenkinsFile Outdated Show resolved Hide resolved
Refactor docker copy into a more streamline script
Co-authored-by: Andre Kurait <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peternied
Copy link
Member

@peterzhuamazon Thanks for this change, we will merge as soon as CI passes - have a great weekend!

Copy link
Member

@AndreKurait AndreKurait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's hold off merging until @sumobrian chimes in and we have bandwidth to test this without blocking a necessary release
Release worked today, will merge to test this

@AndreKurait AndreKurait merged commit 81361f8 into opensearch-project:main Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure migrations and upgrades Used for Issues and Pull Requests related to OpenSearch upgrades and migrations release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[release]: Opensearch Migration ECR Images
4 participants