Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 172 #173

Merged
merged 5 commits into from
Jul 6, 2022
Merged

Fix issue 172 #173

merged 5 commits into from
Jul 6, 2022

Conversation

mtimmerm
Copy link
Contributor

Fix issue 172 -- erroneous implementation of double-check locking caused NPE in clients of LazyDeserializer.

@mtimmerm mtimmerm requested review from a team and madhusudhankonda as code owners June 30, 2022 22:17
@dblock
Copy link
Member

dblock commented Jun 30, 2022 •
edited
Loading

This needs a test, please? To correct DCO amend your commit with git commit --amend -s

Arsnael and others added 4 commits July 1, 2022 08:52
@Arsnael @mtimmermansTa
Sort field in Hit deserializer should handle null events (opensearch-…
5d8919b 
…project#169)

Signed-off-by: Rene Cordier <[email protected]>
Signed-off-by: Matt Timmermans <[email protected]>
@VachaShah @mtimmermansTa
Deprecating master terminology to support inclusive naming (opensearc…
717a492 
…h-project#167)

* Deprecating master terminology to support inclusive naming

Signed-off-by: Vacha Shah <[email protected]>

* Fixing tests against unreleased OpenSearch

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Matt Timmermans <[email protected]>
@mtimmermansTa
Fix issue 172
f9226e4 
Signed-off-by: Matt Timmermans <[email protected]>
@mtimmermansTa
Add test for issue 172
f1b3ef9 
Signed-off-by: Matt Timmermans <[email protected]>
@mtimmerm mtimmerm changed the title Fix issue 172 [DRAFT] Fix issue 172 Jul 1, 2022
@mtimmerm mtimmerm changed the title [DRAFT] Fix issue 172 Fix issue 172 Jul 1, 2022
@mtimmerm mtimmerm mentioned this pull request Jul 1, 2022
Closed
dblock
dblock approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for an answer/update for below before merging

java-client/src/test/java/org/opensearch/client/opensearch/json/JsonpMapperTest.java Show resolved Hide resolved
VachaShah
VachaShah approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mtimmerm!

@VachaShah VachaShah merged commit 63f7108 into opensearch-project:main Jul 6, 2022
@mtimmerm mtimmerm deleted the issue-172 branch July 14, 2022 18:15
@ecastilloseekr
Copy link

Hello, thank you for this fix! Do you guys plan to create a tag with this fix anytime soon? Thank you. @mtimmermansTa @Arsnael

@dblock
Copy link
Member

dblock commented Jul 26, 2022

We have #174 open, working in it, but no immediate ETA, cc: @bbarani @gaiksaya.

@garethcwilliams garethcwilliams mentioned this pull request Jul 28, 2022
Closed
@cb-pankajk cb-pankajk mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@VachaShah VachaShah VachaShah approved these changes

@madhusudhankonda madhusudhankonda Awaiting requested review from madhusudhankonda madhusudhankonda is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mtimmerm @dblock @ecastilloseekr @VachaShah @Arsnael @mtimmermansTa