Deprecating master terminology to support inclusive naming #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <[email protected]>
tlfeng
reviewed
Jun 16, 2022
| @@ -140,9 +140,13 @@ public class NodesRecord implements JsonpSerializable { | |||
| @Nullable | |||
| private final String nodeRole; | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
nit: I think technically private variable or method can be renamed freely without deprecating. 😁
There was a problem hiding this comment.
Missed this, I will update it 🤦🏼♀️
There was a problem hiding this comment.
I think that is fine if not changed, while reducing the code change maybe better. 😄
owaiskazi19
reviewed
Jun 16, 2022
| */ | ||
| public static final MasterRequest _INSTANCE = new MasterRequest(); | ||
| public static final ClusterManagerRequest _INSTANCE = new ClusterManagerRequest(); | ||
|
|
||
| // --------------------------------------------------------------------------------------------- | ||
|
|
||
| /** | ||
| * Endpoint "{@code cat.master}". |
There was a problem hiding this comment.
If we have changed the API request in this PR
master -> cluster_manager
There was a problem hiding this comment.
Do you mean for the comment cat.master? cat.master is for the deprecated endpoint, cat.cluster_manager is for the endpoint.
There was a problem hiding this comment.
I see we are supporting the deprecated and the new endpoint to not break things out there. Makes sense. You can ignore my comment.
Signed-off-by: Vacha Shah <[email protected]>
tlfeng
approved these changes
Jun 16, 2022
owaiskazi19
approved these changes
Jun 21, 2022
saratvemulapalli
approved these changes
Jun 27, 2022
mtimmerm
pushed a commit
to mtimmerm/opensearch-java
that referenced
this pull request
Jul 1, 2022
…h-project#167) * Deprecating master terminology to support inclusive naming Signed-off-by: Vacha Shah <[email protected]> * Fixing tests against unreleased OpenSearch Signed-off-by: Vacha Shah <[email protected]> Signed-off-by: Matt Timmermans <[email protected]>
VachaShah
added a commit
that referenced
this pull request
Jul 6, 2022
* Sort field in Hit deserializer should handle null events (#169) Signed-off-by: Rene Cordier <[email protected]> Signed-off-by: Matt Timmermans <[email protected]> * Deprecating master terminology to support inclusive naming (#167) * Deprecating master terminology to support inclusive naming Signed-off-by: Vacha Shah <[email protected]> * Fixing tests against unreleased OpenSearch Signed-off-by: Vacha Shah <[email protected]> Signed-off-by: Matt Timmermans <[email protected]> * Fix issue 172 Signed-off-by: Matt Timmermans <[email protected]> * Add test for issue 172 Signed-off-by: Matt Timmermans <[email protected]> Co-authored-by: Rene Cordier <[email protected]> Co-authored-by: Vacha Shah <[email protected]> Co-authored-by: Matt Timmermans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah [email protected]
Description
Deprecating master nomenclature for inclusive naming which includes the following changes:
master->cluster-managerin commentsmaster->clusterManagerin methods and variablesmaster->cluster_managerin API parametersIssues Resolved
#166
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.