Removed null constraints on NodeInfo fields that are returned null from Amazon OpenSearch Service #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2024 13:27
…TransportAddress Signed-off-by: Dan Cecoi <[email protected]>
…white space Signed-off-by: Dan Cecoi <[email protected]>
dancristiancecoi
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
Xtansia
requested changes
Aug 8, 2024
Signed-off-by: Dan Cecoi <[email protected]> # Conflicts: # CHANGELOG.md
Xtansia
requested changes
Aug 11, 2024
CHANGELOG.md
Outdated
| @@ -42,6 +42,7 @@ This section is for maintaining a changelog for all breaking changes for the cli | |||
| ### Removed | |||
|
|
|||
| ### Fixed | |||
| - Fixed handling of NodeInfo fields that are not returned by Amazon OpenSearch Service ([#1131](https://github.com/opensearch-project/opensearch-java/pull/1131)) | |||
There was a problem hiding this comment.
Sorry I missed catching this before, it should reference this PR rather than the previous one
Suggested change
| - Fixed handling of NodeInfo fields that are not returned by Amazon OpenSearch Service ([#1131](https://github.com/opensearch-project/opensearch-java/pull/1131)) | |
| - Fixed handling of NodeInfo fields that are not returned by Amazon OpenSearch Service ([#1132](https://github.com/opensearch-project/opensearch-java/pull/1132)) |
There was a problem hiding this comment.
Oops, good catch! I made the changes.
Signed-off-by: Dan Cecoi <[email protected]>
Xtansia
approved these changes
Aug 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
…om Amazon OpenSearch Service (#1132) * Removed the null constraints on NodeInfo.host, NodeInfo.Ip, NodeInfo.TransportAddress Signed-off-by: Dan Cecoi <[email protected]> * Added a CHANGELOG entry, made the getters nullable and removed extra white space Signed-off-by: Dan Cecoi <[email protected]> * modified the PR link in the changelog Signed-off-by: Dan Cecoi <[email protected]> --------- Signed-off-by: Dan Cecoi <[email protected]> Co-authored-by: Dan Cecoi <[email protected]> (cherry picked from commit 94171f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Xtansia
pushed a commit
that referenced
this pull request
Aug 12, 2024
…om Amazon OpenSearch Service (#1132) (#1136) * Removed the null constraints on NodeInfo.host, NodeInfo.Ip, NodeInfo.TransportAddress * Added a CHANGELOG entry, made the getters nullable and removed extra white space * modified the PR link in the changelog --------- (cherry picked from commit 94171f8) Signed-off-by: Dan Cecoi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cecoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes null constraints on NodeInfo.Host, NodeInfo.Ip, NodeInfo.TransportAddress that are returned null from Amazon OpenSearch Service when performing a NodeInfoRequest
Issues Resolved
#1129
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.